Disable building rust-analyzer on riscv64 #75103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
riscv64 has an LLVM bug that makes rust-analyzer not build.
Mark-Simulacrum
force-pushed
the
no-ra-for-riscv64
branch
from
4986e5c to
d2fc809
Compare
|
The other bors @bors r+ |
|
📌 Commit d2fc809 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…r=matklad Disable building rust-analyzer on riscv64 riscv64 has an LLVM bug that makes rust-analyzer not build. Should permit future rust-analyzer ups (e.g., rust-lang#74813) to land.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…r=matklad Disable building rust-analyzer on riscv64 riscv64 has an LLVM bug that makes rust-analyzer not build. Should permit future rust-analyzer ups (e.g., rust-lang#74813) to land.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2020
…r=matklad Disable building rust-analyzer on riscv64 riscv64 has an LLVM bug that makes rust-analyzer not build. Should permit future rust-analyzer ups (e.g., rust-lang#74813) to land.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74759 (add `unsigned_abs` to signed integers) - rust-lang#75043 (rustc_ast: `(Nested)MetaItem::check_name` -> `has_name`) - rust-lang#75056 (Lint path statements to suggest using drop when the type needs drop) - rust-lang#75081 (Fix logging for rustdoc) - rust-lang#75083 (Do not trigger `unused_braces` for `while let`) - rust-lang#75084 (Stabilize Ident::new_raw) - rust-lang#75103 (Disable building rust-analyzer on riscv64) - rust-lang#75106 (Enable docs on in the x86_64-unknown-linux-musl manifest) Failed merges: r? @ghost
|
Is this still the case after so many LLVM releases? |
|
@davidlt if you would like to send a PR to re-enable it, we can try again with current LLVM. Maybe you can test that with a patch on the Fedora riscv infrastructure first? |
|
Thanks for the reminder. I will attempt enabling it in a few days (I will try my best to queue it later today). |
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Jan 18, 2023
It was disabled in rust-lang#75103 due to an LLVM bug, but followup comments have confirmed that it builds fine on Fedora with LLVM 15.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 21, 2023
Re-enable building rust-analyzer on riscv64 It was disabled in rust-lang#75103 due to an LLVM bug, but followup comments have confirmed that it builds fine on Fedora with LLVM 15. r? `@Mark-Simulacrum` cc `@matklad` `@davidlt`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 22, 2023
Re-enable building rust-analyzer on riscv64 It was disabled in rust-lang#75103 due to an LLVM bug, but followup comments have confirmed that it builds fine on Fedora with LLVM 15. r? ``@Mark-Simulacrum`` cc ``@matklad`` ``@davidlt``
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 22, 2023
Re-enable building rust-analyzer on riscv64 It was disabled in rust-lang#75103 due to an LLVM bug, but followup comments have confirmed that it builds fine on Fedora with LLVM 15. r? ```@Mark-Simulacrum``` cc ```@matklad``` ```@davidlt```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riscv64 has an LLVM bug that makes rust-analyzer not build. Should permit future rust-analyzer ups (e.g., #74813) to land.