-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable leak sanitizer test case #68244
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ |
📌 Commit 8b341e4c539d4876fd34a303ee175189f114248b has been approved by |
So I think we might reach the conclusion that because this is 1) in our own test suite under our control and 2) compiled with a toolchain we also fully control, that relying on this might be OK for internal purposes. That said, we currently state that:
So I would like to hear from more folks first (such as e.g. @rkruppe and @RalfJung) to develop a common understanding of our policy here. For now I will temporarily @bors r- |
This is fixing a test and I don't want to deal with policies of using r? @Centril |
* Use `black_box` to avoid memory leak removal during optimization. * Leak multiple objects to make test case more robust.
@bors r+ |
📌 Commit 5d00b5c has been approved by |
Enable leak sanitizer test case * Use `black_box` to avoid memory leak removal during optimization. * Leak multiple objects to make test case more robust.
Enable leak sanitizer test case * Use `black_box` to avoid memory leak removal during optimization. * Leak multiple objects to make test case more robust.
Rollup of 5 pull requests Successful merges: - #68033 (Don't use f64 shims for f32 cmath functions on non 32-bit x86 MSVC) - #68244 (Enable leak sanitizer test case) - #68255 (Remove unused auxiliary file that was replaced with rust_test_helpers) - #68263 (rustdoc: HTML escape codeblocks which fail syntax highlighting) - #68274 (remove dead code) Failed merges: r? @ghost
black_box
to avoid memory leak removal during optimization.