Rollup of 27 pull requests #33643

eddyb · 2016-05-14T19:21:29Z

Successful merges: typeck: if a private field exists, also check for a public method #33342, Add error description for E0455 #33393, Add error explanations for E0374, E0375, E0376 on issue #32777 #33415, Add detailed error explanation for E0505 #33475, Tighten span for E0063 #33517, Add E0500 error explanation #33533, Simplify text #33534, Fix typo in std::sync::Once documentation #33565, Cleanup formatting and wording for std::env::temp_dir docs. #33580, Add more details and examples in error codes #33584, Add compile-fail tests for error codes #33585, add UI testing framework #33588, update "reason" for fnbox feature gate #33590, Use the correct word in the explanation #33591, Improve derived implementations for enums with lots of fieldless variants #33593, doc: Fix comment in std::string::String example code #33598, rustdoc: Fix missing type parameters on impls #33600, Save metadata even with -Z no-trans (e.g. for multi-crate cargo check). #33602, doc: to_string not needed since we gots coercion #33603, doc: line these comments up #33604, doc: use less awkward and less confusing language #33605, Some simple improvements to MIR pretty printing #33607, gdb Pretty Print: generic encoded was failing on reference/pointer types #33612, mir: always allow &mut [...] in static mut regardless of the array length. #33620, doc: this statement does not have an effect #33633, doc: improve output #33634, doc: 'tis the lang, not the reptile #33635
Failed merges: update tracking issue for once_poison #33578

Looks more nice, and same is done with prior examples

rust-highfive · 2016-05-14T19:21:43Z

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2016-05-14T19:21:50Z

@bors r+ p=123

bors · 2016-05-14T19:21:52Z

📌 Commit 72f0bfe has been approved by eddyb

bors · 2016-05-14T21:16:08Z

⌛ Testing commit 72f0bfe with merge bef9056...

bors · 2016-05-14T21:51:37Z

💔 Test failed - auto-mac-64-opt-rustbuild

arielb1 · 2016-05-14T21:56:38Z


/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_const_math/lib.rs:31:14: 31:34 error: can't find crate for `syntax` [E0463]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_const_math/lib.rs:31 #[macro_use] extern crate syntax;
                                                                                                                        ^~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/libsyntax_ext/lib.rs:28:1: 28:21 error: can't find crate for `syntax` [E0463]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/libsyntax_ext/lib.rs:28 extern crate syntax;
                                                                                                     ^~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_back/lib.rs:44:1: 44:21 error: can't find crate for `syntax` [E0463]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_back/lib.rs:44 extern crate syntax;
                                                                                                     ^~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error

?

@bors retry

eddyb · 2016-05-14T21:58:20Z

@arielb1 Yeah I have no explanation either, stage0 compiles but stage1 doesn't and they have the same Cargo.toml's and whatnot. No change in this rollup seems to actually affect any of that code and I can't see how my metadata change could do this.

eddyb · 2016-05-14T21:58:58Z

@bors force

bors · 2016-05-14T21:59:03Z

⌛ Testing commit 72f0bfe with merge 89f8e6a...

bors · 2016-05-14T22:32:45Z

💔 Test failed - auto-mac-64-opt-rustbuild

eddyb · 2016-05-14T22:34:24Z

cc @alexcrichton because I'm dumbfounded again.

alexcrichton · 2016-05-14T22:51:48Z

Was Cargo.toml forgotten to be updated? (sorry on a phone hard to check)

On Saturday, May 14, 2016, Eduard-Mihai Burtescu [email protected]
wrote:

cc @alexcrichton https://github.com/alexcrichton because I'm
dumbfounded again.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#33643 (comment)

eddyb · 2016-05-14T22:53:24Z

@alexcrichton I wish, but I can't find anything like that in the combined diff of the rollup.

alexcrichton · 2016-05-14T23:54:18Z

Looks like the cdylib PR failed for the same reason, I'd back that out and I can investigate it locally

eddyb · 2016-05-15T12:09:31Z

@alexcrichton Bummer, since I have the version of that from a couple days ago in my item_symbols removal PR. Let me know if you figure out what's wrong with it.

doc: to_string not needed since we gots coercion

doc: line these comments up Looks more nice, and same is done with prior examples

doc: use less awkward and less confusing language

@eddyb

…lexcrichton rustbuild: Ignore user config.toml file. r? @eddyb

doc: this statement does not have an effect

doc: improve output

doc: 'tis the lang, not the reptile

Update link to license Permanent redirect (301). The link should be updated.

eddyb · 2016-05-15T23:02:57Z

Whatever, let's get something small going.

@bors r+

bors · 2016-05-15T23:02:58Z

📌 Commit ffbfbe4 has been approved by eddyb

bors · 2016-05-16T01:22:52Z

⌛ Testing commit ffbfbe4 with merge bb39c49...

Rollup of 27 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635 - Failed merges: #33578

bors · 2016-05-16T03:47:13Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

tshepang and others added 7 commits May 12, 2016 23:25

doc: line these comments up

a181d2f

Looks more nice, and same is done with prior examples

doc: use less awkward and less confusing language

10c984a

doc: to_string not needed since we gots coercion

226cb9c

rustbuild: Ignore user config.toml file.

ef53fa7

doc: this statement does not have an effect

deb8165

doc: improve output

971a3af

doc: 'tis the lang, not the reptile

e699e12

rust-highfive assigned nrc May 14, 2016

floftar and others added 3 commits May 15, 2016 19:59

Update link to license

92abda0

Rollup merge of rust-lang#33603 - tshepang:no-need, r=apasel422

752137f

doc: to_string not needed since we gots coercion

Rollup merge of rust-lang#33604 - tshepang:line-em-up, r=GuillaumeGomez

9c745e7

doc: line these comments up Looks more nice, and same is done with prior examples

eddyb force-pushed the rollup branch from 72f0bfe to e7420fb Compare May 15, 2016 23:00

Rollup merge of rust-lang#33605 - tshepang:less-awkward, r=steveklabnik

9cd83eb

doc: use less awkward and less confusing language

eddyb added 5 commits May 16, 2016 02:00

Rollup merge of rust-lang#33631 - solson:ignore-rustbuild-config, r=a…

1155a34

…lexcrichton rustbuild: Ignore user config.toml file. r? @eddyb

Rollup merge of rust-lang#33633 - tshepang:no-effect, r=steveklabnik

76d50e6

doc: this statement does not have an effect

Rollup merge of rust-lang#33634 - tshepang:nicer-output, r=steveklabnik

b0c8972

doc: improve output

Rollup merge of rust-lang#33635 - tshepang:capitalise, r=steveklabnik

b4da51a

doc: 'tis the lang, not the reptile

Rollup merge of rust-lang#33660 - fbergr:doc, r=steveklabnik

ffbfbe4

Update link to license Permanent redirect (301). The link should be updated.

bors merged commit ffbfbe4 into rust-lang:master May 16, 2016

eddyb deleted the rollup branch May 16, 2016 04:01

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 27 pull requests #33643

Rollup of 27 pull requests #33643

eddyb commented May 14, 2016

rust-highfive commented May 14, 2016

eddyb commented May 14, 2016

bors commented May 14, 2016

bors commented May 14, 2016

bors commented May 14, 2016

arielb1 commented May 14, 2016

eddyb commented May 14, 2016 •

edited

Loading

eddyb commented May 14, 2016

bors commented May 14, 2016

bors commented May 14, 2016

eddyb commented May 14, 2016

alexcrichton commented May 14, 2016

eddyb commented May 14, 2016

alexcrichton commented May 14, 2016

eddyb commented May 15, 2016

eddyb commented May 15, 2016

bors commented May 15, 2016

bors commented May 16, 2016

bors commented May 16, 2016

Rollup of 27 pull requests #33643

Rollup of 27 pull requests #33643

Conversation

eddyb commented May 14, 2016

rust-highfive commented May 14, 2016

eddyb commented May 14, 2016

bors commented May 14, 2016

bors commented May 14, 2016

bors commented May 14, 2016

arielb1 commented May 14, 2016

eddyb commented May 14, 2016 • edited Loading

eddyb commented May 14, 2016

bors commented May 14, 2016

bors commented May 14, 2016

eddyb commented May 14, 2016

alexcrichton commented May 14, 2016

eddyb commented May 14, 2016

alexcrichton commented May 14, 2016

eddyb commented May 15, 2016

eddyb commented May 15, 2016

bors commented May 15, 2016

bors commented May 16, 2016

bors commented May 16, 2016

eddyb commented May 14, 2016 •

edited

Loading