test: Increase resolution of MB/s stat for bench runs close to 1 second #30959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
https://play.rust-lang.org/?gist=10fd60f2cd7e5b2e48ac&version=stable numbers taken from the UTF-8 fast path PR, where the benches with duration around 0.1 second and lower showed some loss of resolution in this stat. |
| let mb_s = (bs.bytes * iter_s) / 1_000_000; | ||
| // use iterations per 100s for better resolution in mb_s. | ||
| let iter_per_100s = 100 * 1_000_000_000 / ns_iter; | ||
| let mb_s = (bs.bytes * iter_per_100s) / 100 / 1_000_000; |
There was a problem hiding this comment.
Why don't we simply compute
// let mb_s = bs.bytes * (1_000_000_000 ns/s / 1_000_000 MB/B ) / ns_iter;
let mb_s = bs.bytes * 1_000 / ns_iter;?
There was a problem hiding this comment.
Indeed, that seems good. I don't think we have to worry about overflow, no reason not to do this.
MB/s was based on the number of iterations performed in a second, when the iteration duration nears 1 second (1e9 ns), the resolution of the MB/s stat decreases.
bluss
force-pushed
the
bench-resolution
branch
from
add3522 to
627829b
Compare
|
Updated the commit to use @ranma42's suggestion |
|
@bors r+ Seems legit |
|
📌 Commit 627829b has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 17, 2016
test: Increase resolution of MB/s stat for bench runs close to 1 second MB/s was based on the number of iterations performed in a second, when the iteration duration nears 1 second (1e9 ns), the resolution of the MB/s stat decreases.
bors
added a commit
that referenced
this pull request
Jan 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: Increase resolution of MB/s stat for bench runs close to 1 second
MB/s was based on the number of iterations performed in a second, when
the iteration duration nears 1 second (1e9 ns), the resolution of the
MB/s stat decreases.