Add examples for std::ascii #23665
Merged
Add examples for std::ascii #23665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweaked a few things.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -246,7 +324,7 @@ pub struct EscapeDefault { | |||
| data: [u8; 4], | |||
| } | |||
|
|
|||
| /// Returns a 'default' ASCII and C++11-like literal escape of a `u8` | |||
| /// Returns an iterator that produces an escaped version of a `u8`. | |||
There was a problem hiding this comment.
'default' is mentioned later too, could it be given some better context/antecedent?
There was a problem hiding this comment.
I'm not sure what it means, actually. But you're right it needs one...
|
r=me with or without that nit fixed :) |
|
Ehhh let's just leave the nit for now |
|
@bors: r=manishearth rollup |
|
📌 Commit 528a5e2 has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2015
Also tweaked a few things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweaked a few things.