Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Rename container to collections. Closes #12543 #14333

Closed
wants to merge 1 commit into from

Conversation

brson
Copy link
Contributor

@brson brson commented May 21, 2014

Though I'm sure there are more things to change about the collections traits, this solves the specific complaint in the linked bug by using "collections" consistently.

@brson
Copy link
Contributor Author

brson commented May 21, 2014

Oh, these are all breaking changes. I'll update.

Also renames the `Container` trait to `Collection`.

[breaking-change]
@alexcrichton
Copy link
Member

This may not be quite the change that we want. I think that in an ideal world the entire container module would move into libcollections. The collections library currently has one generic trait Deque (which is of questionable quality).

I'm only hesitant because if that's our long-term goal then I don't think this is moving us any closer to that (we'll still have to rename all imports). The renaming of Container to Collection will probably stay, however.

@brson
Copy link
Contributor Author

brson commented May 23, 2014

OK.

@brson brson closed this May 23, 2014
@liigo
Copy link
Contributor

liigo commented May 23, 2014

One letter longer (Container -> Collection)

@alexcrichton
Copy link
Member

Due to the movement of libcollections, I take back what I said about all imports being renamed. All imports will be renamed to std::collections::Foo anyway (sorry!). I'm working on a rebase of this.

bors added a commit that referenced this pull request Jun 9, 2014
This is mostly just a cosmetic change, continuing the work from #14333.
lnicola pushed a commit to lnicola/rust that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants