test: index shards at 1, not 0 #14286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about a run-make test? |
|
Is there any reason to not keep the 0-based indexing and add a range check? |
|
@sfackler I think having it 1-based makes more sense. "This is shard 1 of 2" and "This is shard 2 of 2" |
|
@huonw what are you thinking that would look like? |
# Makefile
all:
rustc --test foo.rs
./foo --shard 1.2 | grep 'test_1 ... ok'
./foo --shard 2.2 | grep 'test_2 ... ok'// foo.rs
#[test]
fn test_1() {}
#[test]
fn test_2() {}(or similar) |
| DynTestFn(..) => "DynTestFn(..)", | ||
| DynMetricFn(..) => "DynMetricFn(..)", | ||
| DynBenchFn(..) => "DynBenchFn(..)" | ||
| }.as_bytes()).ok().unwrap(); |
There was a problem hiding this comment.
This seems odd, why not just return the result?
|
@alexcrichton I've removed your r+ -- I still need to add a test. |
|
Ah whoops, ok! r=me with a test |
This has no tests because it's near impossible to test -- since TestFn uses `proc`s, they can not be cloned or tested for equality. The only way to really test this is making sure that for a given number of shards `a`, sharding from 1 to `a` yields the complete set of tests. But `filter_tests` takes its vector by value and `proc`s cannot be compared. [breaking-change] Closes #10898
bors
added a commit
that referenced
this pull request
May 19, 2014
This has no tests because it's near impossible to test -- since TestFn uses `proc`s, they can not be cloned or tested for equality. The only way to really test this is making sure that for a given number of shards `a`, sharding from 1 to `a` yields the complete set of tests. But `filter_tests` takes its vector by value and `proc`s cannot be compared. [breaking-change] Closes #10898
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Mar 13, 2023
fix: Fix block defmap not looking into tail expressions for macro calls Fixes rust-lang/rust-analyzer#14263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no tests because it's near impossible to test -- since TestFn uses
procs, they can not be cloned or tested for equality. The only way to reallytest this is making sure that for a given number of shards
a, sharding from1 to
ayields the complete set of tests. Butfilter_teststakes its vectorby value and
procs cannot be compared.[breaking-change]
Closes #10898