Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue to check attr if meet empty repr for adt #138253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Continue to check attr if meet empty repr for adt #138253

wants to merge 1 commit into from
+37 −1

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Mar 9, 2025

Fixes #138241

Returning while checking ReprEmpty results in missing the check for the next repr

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@jdonszelmann
Copy link
Contributor

Feel free to assign me to this one, I can review ir in a bit

@mu001999
Copy link
Contributor Author

mu001999 commented Mar 9, 2025

r? jdonszelmann

@rustbot rustbot assigned jdonszelmann and unassigned davidtwco Mar 9, 2025
@m-ou-se
Copy link
Member

m-ou-se commented Mar 9, 2025

@bors delegate=jdonszelmann

@bors

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2025

📌 Commit 86013e6 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#138253 - mu001999-contrib:fix-138241, r=jdo…
469f48d 
…nszelmann

Continue to check attr if meet empty repr for adt

Fixes rust-lang#138241

Returning while checking ReprEmpty results in missing the check for the next repr
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: computed impossible repr (packed enum?): Foo
6 participants
@mu001999 @rustbot @jdonszelmann @m-ou-se @bors @davidtwco