Rollup of 17 pull requests #138127
Merged
Rollup of 17 pull requests #138127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Intended for e.g. rolling reviewers for adding new targets.
Co-authored-by: MabezDev <[email protected]>
…f imported Use `std::mem::size_of_val` from the prelude instead of importing or qualifying it. This function was added to all preludes in Rust 1.80.
…ynSync"" This reverts commit 8eba29a.
so that it doesn't get removed again
Stabilizes `copy_from_slice` method on `[T]`
Co-authored-by: Rémy Rakic <[email protected]>
Whenever running citool, it leaves behind a target directory. Ignore this like we do for other tools.
Replaced the outdated link to https://github.com/rust-lang/miri/blob/master/src/shims/intrinsics with the correct link https://github.com/rust-lang/miri/tree/master/src/intrinsics in the library/core/src/intrinsics/mod.rs file.
Add timestamp to unstable feature usage metrics part of rust-lang#129485 with this we should be able to temporarily enable metrics on docs.rs to gather a nice test dataset for the initial PoC dashboard r? ```@estebank```
…ostrap-compiletest, r=jieyouxu bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported Use `std::mem::size_of_val` from the prelude instead of importing or qualifying it. This function was added to all preludes in Rust 1.80. r? ``@jieyouxu``
…youxu trim channel value in `get_closest_merge_commit` This was a silly bug which caused `git_upstream_merge_base` to never work because it was `nightly\n` not `nightly`.
Increase the max. custom try jobs requested to `20` Requested [here](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Increase.20try-job.20limit). r? ````@marcoieni````
…ywiser triagebot: add a `compiler_leads` ad-hoc group Intended for e.g. rolling reviewers for [adding new targets](https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#targets). rust-lang/rust-forge side doc update: rust-lang/rust-forge#815 r? ghost (for testing) cc ``@davidtwco`` or ``@wesleywiser``
…=jieyouxu Remove - from xtensa targets cpu names This PR removes the `-` from the Xtensa CPU names as it was updated in LLVM, see esp-rs#252
…rieb Use final path segment for diagnostic Test changes should prove the effect of this PR; we want to mention the *function name* not the arbitrary first segment of the path.
Reduce the noise of bootstrap changelog warnings in --dry-run mode Presently x.py displays "There have been changes to x.py since you last updated:" note only once when run normally, but on every invocation when run with `--dry-run`. The disparity is not exactly intentonal, but just a historical accident. It was made to be printed once in rust-lang#117815 via storing `.last-warned-change-id` on disk in `{config.out}/bootstrap` (i.e. `build/bootstrap`) directory. But that didn't quite work for `--dry-run`, since `{config.out}/bootsrap` points to `build/tmp-dry-run/bootstrap` which *isn't* created in dry-run mode, so file creation fails. This got fixed in rust-lang#118789 and now `--dry-run` does not save `.last-warned-change-id` at all. (Nor does it read it, since it cannot know to read from non-dry-run location) This PR simply stops displaying the changelog altogether in --dry-run mode. <details> <summary>previous attempt (outdated)</summary> This PR takes a different approach, and instead of not-writing the stamp in `--dry-run` mode it instead tries harder to yes-write it, and, specifically, creates `build/tmp-dry-run/bootstrap` directory to do so. If neccessary (i.e. if there are changes newer than the `change-id` stamp of config.toml to warn about). Note that `build/tmp-dry-run/` was *already* being created, so making an extra `boostrap` sub-folder should not meaningfully pollute the build dir. </details> (Apologies for the, perhaps, excessively wordy PR, I'm new to this)
Move `yield` expressions behind their own feature gate In order to make progress with the `iter!` macro (e.g. in rust-lang#137725), we need `yield` expressions to be available without the `coroutines` feature. This PR moves `yield` to be guarded by the `yield_expr` feature so that we can stabilize that independently (or at least, concurrently with the `iter_macro` feature). Note that once `yield` is stable, it will still be an error to use `yield` expressions outside something like a generator or coroutine, and these features remain unstable. r? `@oli-obk`
Git ignore citool's target directory Whenever running citool, it leaves behind a target directory. Ignore this like we do for other tools.
…aethlin Fix broken link to Miri intrinsics in documentation This PR updates an outdated link in the library/core/src/intrinsics/mod.rs file. The previous link, pointing to the Miri repository's src/shims/intrinsics directory, has been replaced with the correct one: https://github.com/rust-lang/miri/tree/master/src/intrinsics. This ensures that users can access the appropriate resources for the relevant intrinsic functions.
…tions, r=compiler-errors Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur My employer is writing a rustc backend and it's my job to resolve conflicts with upstream so I'd like to know when `rustc_codegen_ssa` is being changed =)
[llvm/PassWrapper] use `size_t` when building arg strings While we're unlikely to ever overflow `int` in this case, it's still more proper to use `size_t` consistently when dealing with buffer lengths. If nothing else, this fixes a few `-Wsign-compare` warnings.
rustbot
added
A-compiletest
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 98a48781fe In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 7, 2025
|
Finished benchmarking commit (91a0e16): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 773.206s -> 765.289s (-1.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
size_of_valfrom the prelude instead of imported #138041 (bootstrap and compiletest: Usesize_of_valfrom the prelude instead of imported)get_closest_merge_commit#138046 (trim channel value inget_closest_merge_commit)20#138053 (Increase the max. custom try jobs requested to20)compiler_leadsad-hoc group #138061 (triagebot: add acompiler_leadsad-hoc group)yieldexpressions behind their own feature gate #138081 (Moveyieldexpressions behind their own feature gate)librustdoc: flatten nested ifs #138090 (librustdoc: flatten nested ifs)DynSendandDynSyncimpls forTyCtxt#138092 (Re-addDynSendandDynSyncimpls forTyCtxt)const_copy_from_slice#138098 (Stabilize featureconst_copy_from_slice)rustc_codegen_ssaoccur #138108 (Mention me (WaffleLapkin) when changes torustc_codegen_ssaoccur)size_twhen building arg strings #138117 ([llvm/PassWrapper] usesize_twhen building arg strings)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup