Add exclude to config.toml #137147

Shourya742 · 2025-02-16T18:00:28Z

Closes: #35678

r? @onur-ozkan

rustbot · 2025-02-16T18:00:37Z

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

bors · 2025-02-18T04:33:42Z

☔ The latest upstream changes (presumably #137176) made this pull request unmergeable. Please resolve the merge conflicts.

config.example.toml

onur-ozkan · 2025-02-23T05:55:17Z

@rustbot author

bors · 2025-02-23T09:03:03Z

☔ The latest upstream changes (presumably #137215) made this pull request unmergeable. Please resolve the merge conflicts.

Shourya742 · 2025-02-24T04:56:53Z

@rustbot review

bors · 2025-02-25T20:30:39Z

☔ The latest upstream changes (presumably #137611) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan

LGTM

onur-ozkan · 2025-03-01T06:17:15Z

@bors r+

bors · 2025-03-01T06:17:17Z

📌 Commit a110552 has been approved by onur-ozkan

It is now in the queue for this repository.

Shourya742 · 2025-03-01T07:22:35Z

@rustbot review
cc: @onur-ozkan

onur-ozkan · 2025-03-01T08:53:02Z

Rebase wasn't required, it was already queued.

Again, @bors r+

bors · 2025-03-01T08:53:05Z

📌 Commit 9206960 has been approved by onur-ozkan

It is now in the queue for this repository.

Shourya742 · 2025-03-01T10:49:29Z

Rebase wasn't required, it was already queued.

Again, @bors r+

I saw change_tracker conflicts on github, so thought of rebasing on latest changes on master. Does bors resolve merge conflicts??

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? ```@onur-ozkan```

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR) - rust-lang#137081 (change config.toml to bootstrap.toml) - rust-lang#137103 ({json|html}docck: catch and error on deprecated syntax) - rust-lang#137632 (rustdoc: when merging target features, keep the highest stability) - rust-lang#137684 (Add rustdoc support for `--emit=dep-info[=path]`) - rust-lang#137794 (make qnx pass a test) - rust-lang#137801 (tests: Unignore target modifier tests on all platforms) - rust-lang#137826 (test(codegen): add looping_over_ne_bytes test for rust-lang#133528) Failed merges: - rust-lang#137147 (Add exclude to config.toml) r? `@ghost` `@rustbot` modify labels: rollup

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? ````@onur-ozkan````

Rollup of 13 pull requests Successful merges: - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra) - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137327 (Undeprecate env::home_dir) - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes) - rust-lang#137477 (uefi: Add Service Binding Protocol abstraction) - rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden)) - rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var) - rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums) - rust-lang#137722 (`librustdoc`: 2024 edition! 🎊) - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`) - rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK) Failed merges: - rust-lang#137798 (ci: use ubuntu 24 on arm large runner) r? `@ghost` `@rustbot` modify labels: rollup

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? `````@onur-ozkan`````

Rollup of 10 pull requests Successful merges: - rust-lang#134063 (dec2flt: Clean up float parsing modules) - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra) - rust-lang#136975 (Look for `python3` first on MacOS, not `py`) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs) - rust-lang#137303 (Remove `MaybeForgetReturn` suggestion) - rust-lang#137327 (Undeprecate env::home_dir) - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden)) - rust-lang#137829 (Stabilize [T]::split_off... methods) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-03-04T15:54:00Z

Failed in rollup due to platform separator diff #137988 (comment):

2025-03-04T13:51:52.6516415Z thread 'core::config::tests::test_exclude' panicked at src\bootstrap\src\core\config\tests.rs:530:5:
2025-03-04T13:51:52.6517247Z assertion `left == right` failed
2025-03-04T13:51:52.6517715Z   left: "test\\codegen"
2025-03-04T13:51:52.6518075Z  right: "test/codegen"

@bors r-

bors · 2025-03-05T19:15:04Z

☔ The latest upstream changes (presumably #138058) made this pull request unmergeable. Please resolve the merge conflicts.

Shourya742 · 2025-03-08T04:43:42Z

@rustbot review

onur-ozkan · 2025-03-08T11:10:10Z

@bors r+

bors · 2025-03-08T11:10:12Z

📌 Commit 46c387b has been approved by onur-ozkan

It is now in the queue for this repository.

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? `@onur-ozkan`

Rollup of 16 pull requests Successful merges: - rust-lang#122790 (Apply dllimport in ThinLTO) - rust-lang#136127 (Allow `*const W<dyn A> -> *const dyn A` ptr cast) - rust-lang#136968 (Turn order dependent trait objects future incompat warning into a hard error) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137319 (Stabilize `const_vec_string_slice`) - rust-lang#137885 (tidy: add triagebot checks) - rust-lang#138040 (compiler: Use `size_of` from the prelude instead of imported) - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test) - rust-lang#138084 (Use workspace lints for crates in `compiler/`) - rust-lang#138158 (Move more layouting logic to `rustc_abi`) - rust-lang#138160 (depend more on attr_data_structures and move find_attr! there) - rust-lang#138192 (crashes: couple more tests) - rust-lang#138216 (bootstrap: Fix stack printing when a step cycle is detected) - rust-lang#138232 (Reduce verbosity of GCC build log) - rust-lang#138233 (Windows: Don't link std (and run-make) against advapi32, except on win7) - rust-lang#138242 (Revert "Don't test new error messages with the stage 0 compiler") r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned onur-ozkan Feb 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from e9a9186 to 2bf009d Compare February 16, 2025 20:06

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 2bf009d to 471069b Compare February 19, 2025 02:42

onur-ozkan reviewed Feb 23, 2025

View reviewed changes

config.example.toml Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 471069b to daf8f8d Compare February 23, 2025 16:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from daf8f8d to a110552 Compare February 27, 2025 14:47

onur-ozkan approved these changes Mar 1, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from a110552 to 9206960 Compare March 1, 2025 07:21

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request Mar 2, 2025

Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…

f616b76

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? ```@onur-ozkan```

tgross35 mentioned this pull request Mar 2, 2025

Rollup of 10 pull requests #137879

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 4, 2025

Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…

6299dc6

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? ````@onur-ozkan````

jhpratt mentioned this pull request Mar 4, 2025

Rollup of 13 pull requests #137985

Closed

tgross35 added a commit to tgross35/rust that referenced this pull request Mar 4, 2025

Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…

b74c6d3

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? `````@onur-ozkan`````

tgross35 mentioned this pull request Mar 4, 2025

Rollup of 10 pull requests #137988

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 9206960 to c761532 Compare March 4, 2025 21:40

Shourya742 added 4 commits March 8, 2025 10:08

add exclude to config.toml

c76946a

add test for exclude feature

86ca102

Add change info to change tracker

c7af90d

make test platform agnostic

46c387b

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from c761532 to 46c387b Compare March 8, 2025 04:41

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 8, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 9, 2025

Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-excl…

94a477a

…ude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? `@onur-ozkan`

jieyouxu mentioned this pull request Mar 9, 2025

Rollup of 16 pull requests #138255

Open

update the test_exclude to not use paths with path separators

d07eb8b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add exclude to config.toml #137147

Add exclude to config.toml #137147

Shourya742 commented Feb 16, 2025

rustbot commented Feb 16, 2025

bors commented Feb 18, 2025

onur-ozkan commented Feb 23, 2025

bors commented Feb 23, 2025

Shourya742 commented Feb 24, 2025

bors commented Feb 25, 2025

onur-ozkan left a comment

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 •

edited

Loading

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 •

edited

Loading

jieyouxu commented Mar 4, 2025 •

edited

Loading

bors commented Mar 5, 2025

Shourya742 commented Mar 8, 2025

onur-ozkan commented Mar 8, 2025

bors commented Mar 8, 2025

Add exclude to config.toml #137147

Are you sure you want to change the base?

Add exclude to config.toml #137147

Conversation

Shourya742 commented Feb 16, 2025

rustbot commented Feb 16, 2025

bors commented Feb 18, 2025

onur-ozkan commented Feb 23, 2025

bors commented Feb 23, 2025

Shourya742 commented Feb 24, 2025

bors commented Feb 25, 2025

onur-ozkan left a comment

Choose a reason for hiding this comment

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 • edited Loading

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 • edited Loading

jieyouxu commented Mar 4, 2025 • edited Loading

bors commented Mar 5, 2025

Shourya742 commented Mar 8, 2025

onur-ozkan commented Mar 8, 2025

bors commented Mar 8, 2025

Shourya742 commented Mar 1, 2025 •

edited

Loading

Shourya742 commented Mar 1, 2025 •

edited

Loading

jieyouxu commented Mar 4, 2025 •

edited

Loading