Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run clippy for rustc_codegen_gcc on CI #135478

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Run clippy for rustc_codegen_gcc on CI #135478

merged 1 commit into from
Jan 18, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 14, 2025

Requested on Zulip.

Opening as a draft, since it's not clear which rules should be applied to it.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol marked this pull request as ready for review January 14, 2025 17:19
@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 14, 2025

r? antoyo (for the set of Clippy lints)

Then I'll probably r? infra.

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

Failed to set assignee to antoyo: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 14, 2025

CC @antoyo

@antoyo
Copy link
Contributor

antoyo commented Jan 14, 2025

It seems like it might not be checking for default clippy rules, if I look at the old logs.

For instance, I had this clippy warning about nested if: rust-lang/rustc_codegen_gcc@b4418b8#diff-57280bd8d1f4d94ae3723724e830e30b85be41f350f50feaafcbd084048ec18cL69-L73

Is there any reason why it didn't show if the old logs?

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 14, 2025

Right now, we allow everything, and deny only correctness issues. I guess that I could try to change that to just -D warnings, to use the default settings.

@antoyo
Copy link
Contributor

antoyo commented Jan 14, 2025

Right now, we allow everything, and deny only correctness issues. I guess that I could try to change that to just -D warnings, to use the default settings.

Yes, I would appreciate the same behavior as the CI of cg_gcc, please.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 14, 2025

Well, the Clippy version might be slightly different, but hopefully otherwise it should match now. I'm a bit worried that if we use just -Dwarnings, then when we update Clippy, it might break the build and we might then need to fix rustc_codegen_gcc, which might be a bit annoying. But it seems like it is already expected (rust-lang/rust-forge#782), so I guess that it should be fine.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 14, 2025

r? infra

@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jan 14, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 17, 2025

r? @onur-ozkan

@rustbot rustbot assigned onur-ozkan and unassigned jdno Jan 17, 2025
@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 17, 2025

📌 Commit 6ad9c1d has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 18, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135682 - matthiaskrgr:rollup-cl7zlt1, r=matth…
0493557 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133700 (const-eval: detect more pointers as definitely not-null)
 - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius)
 - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI)
 - rust-lang#135583 (Move `std::pipe::*` into `std::io`)
 - rust-lang#135612 (Include x scripts in tarballs)
 - rust-lang#135624 (ci: mirror buildkit image to ghcr)
 - rust-lang#135661 (Stabilize `float_next_up_down`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 86947bb into rust-lang:master Jan 18, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@rust-timer
Unrolled build for rust-lang#135478
a41c55a 
Rollup merge of rust-lang#135478 - Kobzol:gcc-clippy, r=onur-ozkan

Run clippy for rustc_codegen_gcc on CI

Requested on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Run.20clippy.20for.20rustc_codegen_gcc.20in.20the.20Rust.20CI).

Opening as a draft, since it's not clear which rules should be applied to it.

r? `@ghost`
@Kobzol Kobzol deleted the gcc-clippy branch January 18, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kobzol @rust-log-analyzer @rustbot @antoyo @onur-ozkan @bors @jdno