Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RustWrapper: adapt for rename of Intrinsic::getDeclaration #131552

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Oct 11, 2024

llvm/llvm-project@fa789df renamed getDeclaration to getOrInsertDeclaration.

@rustbot label: +llvm-main

@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Oct 11, 2024
@rust-log-analyzer

This comment has been minimized.

@durin42 durin42 force-pushed the llvm-20-getOrInsertDeclaration branch from 8afbc0d to f7836ed Compare October 11, 2024 16:08
@rust-log-analyzer

This comment has been minimized.

llvm/llvm-project@fa789df renamed
getDeclaration to getOrInsertDeclaration.

@rustbot label: +llvm-main
@durin42 durin42 force-pushed the llvm-20-getOrInsertDeclaration branch from f7836ed to 19345d5 Compare October 11, 2024 16:30
@cuviper
Copy link
Member

cuviper commented Oct 11, 2024

LGTM!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 11, 2024

📌 Commit 19345d5 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#130078 (rustdoc-json: change item ID's repr from a string to an int)
 - rust-lang#131065 (Port sort-research-rs test suite to Rust stdlib tests)
 - rust-lang#131109 (Stabilize `debug_more_non_exhaustive`)
 - rust-lang#131287 (stabilize const_result)
 - rust-lang#131463 (Stabilise `const_char_encode_utf8`.)
 - rust-lang#131543 (coverage: Remove code related to LLVM 17)
 - rust-lang#131552 (RustWrapper: adapt for rename of Intrinsic::getDeclaration)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6f76d6e into rust-lang:master Oct 12, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
Rollup merge of rust-lang#131552 - durin42:llvm-20-getOrInsertDeclaration, r=cuviper

RustWrapper: adapt for rename of Intrinsic::getDeclaration

llvm/llvm-project@fa789df renamed getDeclaration to getOrInsertDeclaration.

`@rustbot` label: +llvm-main
@rustbot rustbot added this to the 1.83.0 milestone Oct 12, 2024
@durin42 durin42 deleted the llvm-20-getOrInsertDeclaration branch December 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants