Rollup of 5 pull requests #130332
Merged
Rollup of 5 pull requests #130332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
…arsan68 bootstrap: Print more debug info when `find_initial_libdir` fails From looking at the failure messages printed by rust-lang#129775, my hypothesis is that `rustc --print=sysroot` sometimes prints the wrong path when the rustc executable is hardlinked in multiple places, at least on my macOS system. However, currently I don't have any concrete evidence of this actually happening. This PR therefore expands on rust-lang#129775 by printing even more information on failure (including the actual rustc path), in the hope that when the failure next occurs we can confirm or reject the hypothesis that `rustc --print=sysroot` is printing the wrong path.
Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation Refactors the check in rust-lang#129847 to not unncessarily call the `closure_by_move_body_def_id` query for async closures that don't *need* a by-move body. Fixes rust-lang#130167
…bzol add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot rust-lang#130040 is [reverted](rust-lang#130292) because adding component binaries directly to the dist tarball of the compiler caused conflicts (see rust-lang#130291 and rust-lang/rustup#4019). This PR solves the original problem without touching the dist tarball. r? Kobzol
…-in-tests, r=Kobzol avoid updating LLVM submodule during bootstrap unit tests To test this, make sure you don't have `src/llvm-project` fetched and then set `llvm.download-ci-llvm=true` and run `x test bootstrap`.
`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord` These types don't really admit a natural ordering and no code seems to rely on it, so let's remove it.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry (failed to delete miri) |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 23b04c0513 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (4a47e8e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.2%, secondary -3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 756.265s -> 758.501s (0.30%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
find_initial_libdirfails #130138 (bootstrap: Print more debug info whenfind_initial_libdirfails)ProjectionElemandUnOp/BinOpdont need to bePartialOrd/Ord#130317 (ProjectionElemandUnOp/BinOpdont need to bePartialOrd/Ord)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup