Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #127597

Closed
wants to merge 24 commits into from
Closed

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Jul 11, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

compiler-errors and others added 24 commits June 28, 2024 18:33
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
ALso fixed a bug in the original implementation

Signed-off-by: Jiahao XU <[email protected]>
Co-authored-by: Alphyr <[email protected]>
That would give it alignment of 1 which is ABI-incompatible with its C
definition.
…, r=oli-obk

Implement simple, unstable lint to suggest turning closure-of-async-block into async-closure

We want to eventually suggest people to turn `|| async {}` to `async || {}`. This begins doing that. It's a pretty rudimentary lint, but I wanted to get something down so I wouldn't lose the code.

Tracking:
* rust-lang#62290
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
…hpratt

Don't mark `DEBUG_EVENT` struct as `repr(packed)`

That would give it alignment of 1 which is ABI-incompatible with its C definition.
@rustbot rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 11, 2024
@rustbot rustbot added the rollup A PR which is a rollup label Jul 11, 2024
@jhpratt
Copy link
Member Author

jhpratt commented Jul 11, 2024

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Jul 11, 2024

📌 Commit 0acaa2b has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 11, 2024
Rollup of 3 pull requests

Successful merges:

 - rust-lang#127097 (Implement simple, unstable lint to suggest turning closure-of-async-block into async-closure)
 - rust-lang#127153 (Initial implementation of anonymous_pipe API)
 - rust-lang#127572 (Don't mark `DEBUG_EVENT` struct as `repr(packed)`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jul 11, 2024

⌛ Testing commit 0acaa2b with merge bf41c00...

@rust-log-analyzer
Copy link
Collaborator

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   --> library/std/src/sys/anonymous_pipe/mod.rs:31:23
    |
30  | #[derive(Debug)]
    |          ----- in this derive macro expansion
31  | pub struct PipeReader(AnonPipe);
    |                       ^^^^^^^^ `AnonPipe` cannot be formatted using `{:?}`
   ::: /checkout/library/core/src/fmt/mod.rs:651:5
    |
651 |     pub macro Debug($item:item) {
    |     --------------- in this expansion of `#[derive(Debug)]`
    |     --------------- in this expansion of `#[derive(Debug)]`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `AnonPipe`, which is required by `&AnonPipe: core::fmt::Debug`
    = note: add `#[derive(Debug)]` to `AnonPipe` or manually `impl core::fmt::Debug for AnonPipe`
help: consider annotating `AnonPipe` with `#[derive(Debug)]`
   --> library/std/src/sys/pal/wasi/../unsupported/pipe.rs:3:1
3   + #[derive(Debug)]
4   | pub struct AnonPipe(!);
    |


error[E0277]: `AnonPipe` doesn't implement `core::fmt::Debug`
   --> library/std/src/sys/anonymous_pipe/mod.rs:36:23
    |
35  | #[derive(Debug)]
    |          ----- in this derive macro expansion
36  | pub struct PipeWriter(AnonPipe);
    |                       ^^^^^^^^ `AnonPipe` cannot be formatted using `{:?}`
   ::: /checkout/library/core/src/fmt/mod.rs:651:5
    |
651 |     pub macro Debug($item:item) {
    |     --------------- in this expansion of `#[derive(Debug)]`
    |     --------------- in this expansion of `#[derive(Debug)]`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `AnonPipe`, which is required by `&AnonPipe: core::fmt::Debug`
    = note: add `#[derive(Debug)]` to `AnonPipe` or manually `impl core::fmt::Debug for AnonPipe`
help: consider annotating `AnonPipe` with `#[derive(Debug)]`
   --> library/std/src/sys/pal/wasi/../unsupported/pipe.rs:3:1
3   + #[derive(Debug)]
4   | pub struct AnonPipe(!);
    |

@bors
Copy link
Contributor

bors commented Jul 11, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 11, 2024
@jhpratt jhpratt closed this Jul 11, 2024
@jhpratt jhpratt deleted the rollup-yuypa59 branch July 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like O-windows Operating system: Windows rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants