Fixed Gc::clone, implemented Gc::ptr_eq #11369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| //let mut reader = ErroringLaterReader { | ||
| //count: 0, | ||
| //}; |
There was a problem hiding this comment.
This entire test is sadly all commented out, the variable wasn't being used at all.
There was a problem hiding this comment.
As the next-line comment says: // FIXME (#7049): Figure out some other way to do this.
|
Because the reader is not used anywhere in this function, everything else is commented out with a comment: |
bors
added a commit
that referenced
this pull request
Jan 9, 2014
-Fixed Gc::clone to not require a Clone implementation for T -Implemented Gc::ptr_eq to match Rc::ptr_eq, added a test for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixed Gc::clone to not require a Clone implementation for T
-Implemented Gc::ptr_eq to match Rc::ptr_eq, added a test for that