Make RPITITs assume/require their parent method's predicates #113215
Conversation
rustbot
added
S-waiting-on-review
| help: consider removing the leading `&`-reference | ||
| | | ||
| LL - MyTrait::foo(&self) | ||
| LL + MyTrait::foo(self) | ||
| | |
There was a problem hiding this comment.
I don't know why exactly this suggestion changed, but if you look below, the new "help: the trait MyTrait is implemented for Outer" is actually emitted instead, so I don't really consider this to be a regression.
Also this suggestion isn't even right, I think?
There was a problem hiding this comment.
Yes and even removing & doesn't help in any way.
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
rpitit-predicates-tweaks
branch
from
72398bf to
b0ab37e
Compare
compiler-errors
changed the title
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (0130c3a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.726s -> 670.369s (-0.05%) |
Removes a FIXME from the
param_envquery where we were manually adding the parent function's predicates to the RPITIT's assumptions.r? @spastorino