Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references for L4re that are not defined. #103966

Closed
wants to merge 3 commits into from
Closed

Remove references for L4re that are not defined. #103966

wants to merge 3 commits into from

Conversation

ManuelvOK
Copy link

A couple of signals are not defined for L4re. The same applies for most libunwind calls. This PR removes the references for l4re.

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 4, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

m-ou-se
m-ou-se reviewed Dec 28, 2022
View reviewed changes
library/std/src/personality/gcc.rs
@@ -35,6 +35,7 @@
//!
//! Once stack has been unwound down to the handler frame level, unwinding stops
//! and the last personality routine transfers control to the catch block.
#![cfg(not(target_os = "l4re"))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go in the cfg_if in library/std/src/personality.rs instead.

@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2022
@bors
Copy link
Contributor

bors commented Jan 20, 2023

☔ The latest upstream changes (presumably #107105) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

@ManuelvOK any updates on this?

@Dylan-DPC
Copy link
Member

Closing this as inactive

@Dylan-DPC Dylan-DPC closed this Feb 27, 2023
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2023
@hargoniX hargoniX mentioned this pull request Jun 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2023
@bors
Auto merge of rust-lang#112595 - hargoniX:l4re_fix, r=Mark-Simulacrum
ed7281e 
fix: get the l4re target working again

This is based on work from rust-lang#103966, addressing the review comment by `@m-ou-se` at the time and "fixing" the (probably newly) missing read_buf.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jun 18, 2023
@bors
Auto merge of #112595 - hargoniX:l4re_fix, r=Mark-Simulacrum
3aaa91d 
fix: get the l4re target working again

This is based on work from rust-lang/rust#103966, addressing the review comment by `@m-ou-se` at the time and "fixing" the (probably newly) missing read_buf.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Aug 24, 2023
@bors
Auto merge of #112595 - hargoniX:l4re_fix, r=Mark-Simulacrum
3a7c906 
fix: get the l4re target working again

This is based on work from rust-lang/rust#103966, addressing the review comment by `@m-ou-se` at the time and "fixing" the (probably newly) missing read_buf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ManuelvOK @rustbot @bors @Dylan-DPC @m-ou-se