Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote x86_64-rumprun-netbsd target #81514

Closed
nikic opened this issue Jan 29, 2021 · 6 comments · Fixed by #82594
Closed

Demote x86_64-rumprun-netbsd target #81514

nikic opened this issue Jan 29, 2021 · 6 comments · Fixed by #82594
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikic
Copy link
Contributor

nikic commented Jan 29, 2021

The x86_64-rumprun-netbsd is currently a Tier 2 std target built on dist-various-1. In the course of updating that image, I found that the rumprun project appears to be unmaintained. There has been little activity recently (https://github.com/rumpkernel/rumprun) and there are outstanding PRs to fix build issues. The http://www.rumpkernel.org/ domain is down.

It is still possible to build rumprun on newer Ubuntu versions with the following rather minor adjustment:

diff --git a/src/ci/docker/host-x86_64/dist-various-1/build-rumprun.sh b/src/ci/docker/host-x86_64/dist-various-1/build-rumprun.sh
index 103dbbe6fda..bee2d7a476c 100755
--- a/src/ci/docker/host-x86_64/dist-various-1/build-rumprun.sh
+++ b/src/ci/docker/host-x86_64/dist-various-1/build-rumprun.sh
@@ -20,9 +20,10 @@ exit 1
 
 git clone https://github.com/rumpkernel/rumprun
 cd rumprun
-git reset --hard 39a97f37a85e44c69b662f6b97b688fbe892603b
+git reset --hard b04d42225a12a6fae57a78a9c1cf23642e46cd00
 git submodule update --init
 
-CC=cc hide_output ./build-rr.sh -d /usr/local hw
+# Disable -Werror, to avoid breaking the build with newer compilers.
+CC=cc NOGCCERROR=1 hide_output ./build-rr.sh -d /usr/local hw
 cd ..
 rm -rf rumprun

However, I question the utility of keeping an unmaintained project as a Tier 2 target.

@nagisa nagisa added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2021
@nagisa
Copy link
Member

nagisa commented Jan 30, 2021

Nominating for T-compiler discussion. I suspect that the team will be comfortable with the demotion unless somebody expresses a justified reason why the demotion should not be demoted.

@apiraino
Copy link
Contributor

apiraino commented Feb 4, 2021

agreed to demote and drop support during compiler team meeting

@nagisa
Copy link
Member

nagisa commented Feb 4, 2021

We discussed this during the @rust-lang/compiler meeting today.

This FCP is for the removal of this target from rustc. We felt that this target is somewhat similar to the Windows XP situation, support for which was removed recently as part of this MCP in that the target is unmaintained for long enough that removing it is well warranted.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 4, 2021

Team member @nagisa has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 4, 2021
@rfcbot
Copy link

rfcbot commented Feb 11, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 19, 2021
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Feb 21, 2021
@rfcbot
Copy link

rfcbot commented Feb 21, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 25, 2021
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 28, 2021
…chenkov

Remove the x86_64-rumprun-netbsd target

Herein we remove the target from the compiler and the code from libstd intended to support the now-defunct rumprun project.

Closes rust-lang#81514
@bors bors closed this as completed in a757fae Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants