Code under the 2-clause-BSD license is not documented as a compatible license for the Rust runtime

[gnzlbg]

The 2-clause-BSD license is not documented in the tidy script as being a compatible license for the rust runtime dependencies. We used to ship BSD licensed code as part of libstd until recently: 0b85b64#diff-4131508972c86fdd799a5f7d41fdd323 and we shipped jemalloc for a long time as part of the runtime on many targets.

We still do ship code with the MPL2.0 license in some targets, see: https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/deps.rs#L51

The deps check of the tidy script should be better documented to explain what's allowed and what isn't.

[Mark-Simulacrum]

We discussed this a bit today and concluded that we don't need the SGX dependencies to be appropriately licensed (they're somewhat "third party") so I'm closing this issue.

[gnzlbg]

So does that mean that it is ok to add third party libraries to the runtime under this license?

If so the documentation comment in the tidy script should be updated.

[Mark-Simulacrum]

Not in general. In this case, it's specifically for SGX so that's why we're not concerned about it.

[gnzlbg]

This issue was way broader than SGX is using an incompatible license.

…

On Wed 17. Jul 2019 at 23:51, Mark Rousskov ***@***.***> wrote: Not in general. In this case, it's specifically for SGX so that's why we're not concerned about it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#62620?email_source=notifications&email_token=AAG43JURET3OXOLHVGDCMUDP76H4HA5CNFSM4ICIPZMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2GWDVY#issuecomment-512582103>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG43JRB3XAXZP4XKAN4DNTP76H4HANCNFSM4ICIPZMA> .