Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rustc::middle::region::Scope's fields public... #54122

Closed
oli-obk opened this issue Sep 11, 2018 · 1 comment
Closed

Make rustc::middle::region::Scope's fields public... #54122

oli-obk opened this issue Sep 11, 2018 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Sep 11, 2018 •
edited
Loading

... and remove the entire impl block for constructing values of type Scope

This will cause a lot of fallout throughout the compiler requiring changing Scope::Foo(x) to Scope { id: x, data: ScopeData::Foo }

cc #54032 (comment)

First #54032 needs to get merged though.
@oli-obk oli-obk added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Sep 11, 2018
@oli-obk oli-obk mentioned this issue Sep 11, 2018
Merged
@maxdeviant
Copy link
Contributor

@oli-obk I can take a look at this, if you'd like 👍

@maxdeviant maxdeviant mentioned this issue Sep 15, 2018
Merged
3 tasks
bors added a commit that referenced this issue Sep 17, 2018
@bors
Auto merge of #54260 - maxdeviant:public-scope-fields, r=petrochenkov
ed94397 
Make rustc::middle::region::Scope's fields public

This PR makes the following changes to `rustc::middle::region::Scope`:

- [x] Makes `region::Scope`'s fields public
- [x] Removes the `impl Scope` block with constructors (as per [this comment](#54032 (comment)))
- [x] Updates call sites throughout the compiler

Closes #54122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @maxdeviant