Tracking issue for formatting with a radix #27728

alexcrichton · 2015-08-12T18:08:13Z

This is a tracking issue for the unstable fmt_radix feature in the standard library. These functions provide the ability to format a number in an arbitrary radix. Note that base 2, 8, and 10, and 16 are already supported via various formatting flags.

Needs a decision about whether this functionality should even be in the standard library, and it will perhaps want a different interface as well.

The text was updated successfully, but these errors were encountered:

steveklabnik · 2015-10-27T14:52:09Z

#18301 was an open issue related to an older version of this code.

alexcrichton · 2015-12-16T21:54:47Z

Nominating for removal

alexcrichton · 2015-12-17T22:28:10Z

🔔 This issue is now entering its final comment period for deprecation 🔔

alexcrichton · 2016-01-15T17:48:32Z

The libs team discussed this in triage recently and the decision was to deprecate

This commit stabilizes and deprecates the FCP (final comment period) APIs for the upcoming 1.7 beta release. The specific APIs which changed were: Stabilized * `Path::strip_prefix` (renamed from `relative_from`) * `path::StripPrefixError` (new error type returned from `strip_prefix`) * `Ipv4Addr::is_loopback` * `Ipv4Addr::is_private` * `Ipv4Addr::is_link_local` * `Ipv4Addr::is_multicast` * `Ipv4Addr::is_broadcast` * `Ipv4Addr::is_documentation` * `Ipv6Addr::is_unspecified` * `Ipv6Addr::is_loopback` * `Ipv6Addr::is_unique_local` * `Ipv6Addr::is_multicast` * `Vec::as_slice` * `Vec::as_mut_slice` * `String::as_str` * `String::as_mut_str` * `<[T]>::clone_from_slice` - the `usize` return value is removed * `<[T]>::sort_by_key` * `i32::checked_rem` (and other signed types) * `i32::checked_neg` (and other signed types) * `i32::checked_shl` (and other signed types) * `i32::checked_shr` (and other signed types) * `i32::saturating_mul` (and other signed types) * `i32::overflowing_add` (and other signed types) * `i32::overflowing_sub` (and other signed types) * `i32::overflowing_mul` (and other signed types) * `i32::overflowing_div` (and other signed types) * `i32::overflowing_rem` (and other signed types) * `i32::overflowing_neg` (and other signed types) * `i32::overflowing_shl` (and other signed types) * `i32::overflowing_shr` (and other signed types) * `u32::checked_rem` (and other unsigned types) * `u32::checked_neg` (and other unsigned types) * `u32::checked_shl` (and other unsigned types) * `u32::saturating_mul` (and other unsigned types) * `u32::overflowing_add` (and other unsigned types) * `u32::overflowing_sub` (and other unsigned types) * `u32::overflowing_mul` (and other unsigned types) * `u32::overflowing_div` (and other unsigned types) * `u32::overflowing_rem` (and other unsigned types) * `u32::overflowing_neg` (and other unsigned types) * `u32::overflowing_shl` (and other unsigned types) * `u32::overflowing_shr` (and other unsigned types) * `ffi::IntoStringError` * `CString::into_string` * `CString::into_bytes` * `CString::into_bytes_with_nul` * `From<CString> for Vec<u8>` * `From<CString> for Vec<u8>` * `IntoStringError::into_cstring` * `IntoStringError::utf8_error` * `Error for IntoStringError` Deprecated * `Path::relative_from` - renamed to `strip_prefix` * `Path::prefix` - use `components().next()` instead * `os::unix::fs` constants - moved to the `libc` crate * `fmt::{radix, Radix, RadixFmt}` - not used enough to stabilize * `IntoCow` - conflicts with `Into` and may come back later * `i32::{BITS, BYTES}` (and other integers) - not pulling their weight * `DebugTuple::formatter` - will be removed * `sync::Semaphore` - not used enough and confused with system semaphores Closes rust-lang#23284 cc rust-lang#27709 (still lots more methods though) Closes rust-lang#27712 Closes rust-lang#27722 Closes rust-lang#27728 Closes rust-lang#27735 Closes rust-lang#27729 Closes rust-lang#27755 Closes rust-lang#27782 Closes rust-lang#27798

This commit stabilizes and deprecates the FCP (final comment period) APIs for the upcoming 1.7 beta release. The specific APIs which changed were: Stabilized * `Path::strip_prefix` (renamed from `relative_from`) * `path::StripPrefixError` (new error type returned from `strip_prefix`) * `Ipv4Addr::is_loopback` * `Ipv4Addr::is_private` * `Ipv4Addr::is_link_local` * `Ipv4Addr::is_multicast` * `Ipv4Addr::is_broadcast` * `Ipv4Addr::is_documentation` * `Ipv6Addr::is_unspecified` * `Ipv6Addr::is_loopback` * `Ipv6Addr::is_unique_local` * `Ipv6Addr::is_multicast` * `Vec::as_slice` * `Vec::as_mut_slice` * `String::as_str` * `String::as_mut_str` * `<[T]>::clone_from_slice` - the `usize` return value is removed * `<[T]>::sort_by_key` * `i32::checked_rem` (and other signed types) * `i32::checked_neg` (and other signed types) * `i32::checked_shl` (and other signed types) * `i32::checked_shr` (and other signed types) * `i32::saturating_mul` (and other signed types) * `i32::overflowing_add` (and other signed types) * `i32::overflowing_sub` (and other signed types) * `i32::overflowing_mul` (and other signed types) * `i32::overflowing_div` (and other signed types) * `i32::overflowing_rem` (and other signed types) * `i32::overflowing_neg` (and other signed types) * `i32::overflowing_shl` (and other signed types) * `i32::overflowing_shr` (and other signed types) * `u32::checked_rem` (and other unsigned types) * `u32::checked_shl` (and other unsigned types) * `u32::saturating_mul` (and other unsigned types) * `u32::overflowing_add` (and other unsigned types) * `u32::overflowing_sub` (and other unsigned types) * `u32::overflowing_mul` (and other unsigned types) * `u32::overflowing_div` (and other unsigned types) * `u32::overflowing_rem` (and other unsigned types) * `u32::overflowing_neg` (and other unsigned types) * `u32::overflowing_shl` (and other unsigned types) * `u32::overflowing_shr` (and other unsigned types) * `ffi::IntoStringError` * `CString::into_string` * `CString::into_bytes` * `CString::into_bytes_with_nul` * `From<CString> for Vec<u8>` * `From<CString> for Vec<u8>` * `IntoStringError::into_cstring` * `IntoStringError::utf8_error` * `Error for IntoStringError` Deprecated * `Path::relative_from` - renamed to `strip_prefix` * `Path::prefix` - use `components().next()` instead * `os::unix::fs` constants - moved to the `libc` crate * `fmt::{radix, Radix, RadixFmt}` - not used enough to stabilize * `IntoCow` - conflicts with `Into` and may come back later * `i32::{BITS, BYTES}` (and other integers) - not pulling their weight * `DebugTuple::formatter` - will be removed * `sync::Semaphore` - not used enough and confused with system semaphores Closes rust-lang#23284 cc rust-lang#27709 (still lots more methods though) Closes rust-lang#27712 Closes rust-lang#27722 Closes rust-lang#27728 Closes rust-lang#27735 Closes rust-lang#27729 Closes rust-lang#27755 Closes rust-lang#27782 Closes rust-lang#27798

SimonSapin · 2016-01-18T14:20:50Z

So libstd does not provide any way to do the reverse of e.g. std::u32::from_str_radix with bases other than 2, 8, 10, or 16?

(Maybe that’s ok, the asymmetry is just unusual.)

alexcrichton · 2016-01-18T18:23:39Z

@SimonSapin for now yeah that's the state of affairs

EvanCarroll · 2021-09-03T22:59:14Z

@alexcrichton is there a reason why this feature was deprecated? It sounds extremely useful.

gilescope · 2022-04-12T06:57:07Z

It is useful. I needed it to test the optimised number parsing algorithm, so the tests of std lib now include this functionality even if we do not want to expose it. Personally it seems asymmetric to have one function and not the inverse. (If we already have this code somewhere else in the std lib test code then let me know and I will call that and remove the implementation that I introduced)

#95399

gilescope · 2022-04-16T18:53:01Z

Ah, I see the std lib has does ship this code, it's just not exposed because...

rust/library/core/src/fmt/num.rs

Line 67 in d9b3ff7

    
               fn fmt_int<T: DisplayInt>(&self, mut x: T, f: &mut fmt::Formatter<'_>) -> fmt::Result {

alexcrichton added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Aug 12, 2015

steveklabnik mentioned this issue Oct 27, 2015

Allow implementation of Show for RadixFmt with user-defined type #18301

Closed

alexcrichton added the I-nominated label Dec 16, 2015

alexcrichton added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed I-nominated labels Dec 17, 2015

alexcrichton mentioned this issue Jan 15, 2016

std: Stabilize APIs for the 1.7 release #30943

Merged

bors closed this as completed in #30943 Jan 17, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for formatting with a radix #27728

Tracking issue for formatting with a radix #27728

alexcrichton commented Aug 12, 2015

steveklabnik commented Oct 27, 2015

alexcrichton commented Dec 16, 2015

alexcrichton commented Dec 17, 2015

alexcrichton commented Jan 15, 2016

SimonSapin commented Jan 18, 2016

alexcrichton commented Jan 18, 2016

EvanCarroll commented Sep 3, 2021 •

edited

Loading

gilescope commented Apr 12, 2022

gilescope commented Apr 16, 2022

Tracking issue for formatting with a radix #27728

Tracking issue for formatting with a radix #27728

Comments

alexcrichton commented Aug 12, 2015

steveklabnik commented Oct 27, 2015

alexcrichton commented Dec 16, 2015

alexcrichton commented Dec 17, 2015

alexcrichton commented Jan 15, 2016

SimonSapin commented Jan 18, 2016

alexcrichton commented Jan 18, 2016

EvanCarroll commented Sep 3, 2021 • edited Loading

gilescope commented Apr 12, 2022

gilescope commented Apr 16, 2022

EvanCarroll commented Sep 3, 2021 •

edited

Loading