Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for const_char_classify #132241

Open
2 of 4 tasks
ultrabear opened this issue Oct 27, 2024 · 5 comments · May be fixed by #138129
Open
2 of 4 tasks

Tracking Issue for const_char_classify #132241

ultrabear opened this issue Oct 27, 2024 · 5 comments · May be fixed by #138129
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Comments

@ultrabear
Copy link
Contributor

ultrabear commented Oct 27, 2024

Feature gate: #![feature(const_char_is_digit)] #![feature(const_char_classify)]

This is a tracking issue for supporting char::is_digit and char::is_whitespace in const scenarios.

Public API

impl char {
    pub const fn is_digit(self, radix: u32) -> bool;
    pub const fn is_whitespace(self) -> bool;
}

Steps / History

Unresolved Questions

  • None yet.
@ultrabear ultrabear added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 27, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this issue Oct 28, 2024
Support `char::is_digit` in const contexts.

This PR implements [`feature(const_char_is_digit)` rust-lang#132241](rust-lang#132241)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 28, 2024
Rollup merge of rust-lang#132242 - ultrabear:const_is_digit, r=scottmcm

Support `char::is_digit` in const contexts.

This PR implements [`feature(const_char_is_digit)` rust-lang#132241](rust-lang#132241)
@ultrabear ultrabear changed the title Tracking Issue for const_char_is_digit Tracking Issue for const_char_classify Nov 5, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 6, 2024
…=jhpratt

make char::is_whitespace unstably const

I am adding this to the existing rust-lang#132241 feature gate, since `is_digit` and `is_whitespace` seem similar enough that one can group them together.
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Nov 9, 2024
make char::is_whitespace unstably const

I am adding this to the existing rust-lang/rust#132241 feature gate, since `is_digit` and `is_whitespace` seem similar enough that one can group them together.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Nov 28, 2024
make char::is_whitespace unstably const

I am adding this to the existing rust-lang/rust#132241 feature gate, since `is_digit` and `is_whitespace` seem similar enough that one can group them together.
@RalfJung
Copy link
Member

@rust-lang/libs-api @rust-lang/wg-const-eval these are two fairly small methods that have been stable since 1.0 and that are trivial to const-stabilize, so I think we should go ahead and do that. :)

impl char {
    pub const fn is_digit(self, radix: u32) -> bool;
    pub const fn is_whitespace(self) -> bool;
}

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Feb 24, 2025
@dtolnay
Copy link
Member

dtolnay commented Feb 24, 2025

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 24, 2025

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 24, 2025
@dtolnay dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Feb 24, 2025
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 24, 2025
@rfcbot
Copy link

rfcbot commented Feb 24, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 6, 2025
@rfcbot
Copy link

rfcbot commented Mar 6, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Mar 6, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Mar 7, 2025
…=tgross35

Stabilize const_char_classify, const_sockaddr_setters

FCP for const_char_classify: rust-lang#132241
FCP for const_sockaddr_setters: rust-lang#131714

Fixes rust-lang#132241
Fixes rust-lang#131714

Cc `@rust-lang/wg-const-eval`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants