Add Clippy to CI #55
Merged
Add Clippy to CI #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see how much Clippy is suggesting? Feel free to close the PR if it gets in the way right now 👍 |
|
Oh, I am unfortunately in the middle of rewriting significant chunks of the library :( I’ll get to this PR eventually, but probably not today :-) |
|
That's what I saw :) In any case, so far it looks like there are only ~10 suggestions by Clippy. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 29, 2018
55: Add Clippy to CI r=matklad a=phansch Fixes #19 Co-authored-by: Philipp Hansch <[email protected]>
|
Let's just see how this works out :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19