unresolved import: `thiserror::Error` #6053

bryanburgers · 2020-09-21T16:33:00Z

In the latest version of rust-analyzer (on nvim+coc, but a coworker is reporting the same thing on VSCode), I'm getting the following error from rust-analyzer.

[rust-analyzer] [E] unresolved import

This happens even though a regular build of the project finishes just fine.

thiserror::Error is a derive macro without an accompanying trait (c.f. serde::Serialize, which is a derive macro and also a trait, which does not cause an error).

Could there be a regression with importing derive macro traits?

The text was updated successfully, but these errors were encountered:

kbleeke · 2020-09-21T16:42:02Z

I'm having a similar issue with snafu::Snafu (another error-handling derive macro)

bjorn3 · 2020-09-21T17:24:41Z

You can enable proc-macro support using

{
    "rust-analyzer.cargo.loadOutDirsFromCheck": true,
    "rust-analyzer.procMacro.enable": true,
}

Systemcluster · 2020-09-21T19:28:20Z

I had the same issue with derive macro imports after the latest update with an existing project, but cleaning the target, rebuilding the project and reloading the editor solved it. I still don't get any information on hover (it's stuck at "Loading..."), but I don't know if that was already the case in the previous version.

kbleeke · 2020-09-21T19:44:09Z

You can enable proc-macro support using

{
    "rust-analyzer.cargo.loadOutDirsFromCheck": true,
    "rust-analyzer.procMacro.enable": true,
}

I thought, I had this enabled but apparently it was only in workspace settings of another workspace 🤦 . Fixed for me at least

EverlastingBugstopper · 2020-09-25T16:33:07Z

You can enable proc-macro support using

{
    "rust-analyzer.cargo.loadOutDirsFromCheck": true,
    "rust-analyzer.procMacro.enable": true,
}

This worked for me! Is there any reason this isn't enabled by default? It seems like this is a fairly common use case/language feature.

lnicola · 2020-09-25T16:36:21Z

~~It can be a security risk (you might load a project with a malicious build scripts)~~, it slows down the first load of the project (because we need to compile them), it can slow down the analysis, it doesn't always work (because of ABI differences, e.g. proc macros ~~don't work in nightly and beta right now and we can't fix them without breaking stable users~~ they work since yesterday).

PS: cargo check is enabled by default, so maybe the security aspect is moot.

bjorn3 · 2020-09-25T16:37:44Z

It can be a security risk (you might load a project with a malicious build scripts)

That already happens with cargo check.

kellpossible · 2020-09-29T11:43:35Z

You can enable proc-macro support using

Enabling those options worked for me but they made RA super slow to the point where I can't use it, and have to put up with the errors for now.

bjorn3 · 2020-09-29T11:47:23Z

You can use "rust-analyzer.diagnostics.disabled": ["unresolved-import"] to disable the errors for this. It is already disabled in the latest version by default I think. (#6085)

sunjay · 2020-09-29T18:04:17Z

I seem to be getting the unresolved import error for thiserror::Error regardless of whether I have procMacro enabled. I am on rust-analyzer version: nightly (7b674f9).

bjorn3 · 2020-09-29T19:41:32Z

Do you also have "rust-analyzer.cargo.loadOutDirsFromCheck": true?

sunjay · 2020-09-29T19:57:45Z

Yes. Sorry, I should have posted my config:

{
    "rust-analyzer.updates.channel": "nightly",
    "rust-analyzer.procMacro.enable": true,
    "rust-analyzer.cargo.loadOutDirsFromCheck": true,
    "rust-analyzer.inlayHints.parameterHints": false,
}

This just started happening today when I updated to the latest nightly. (My previous comment has the version)

Ten0 · 2020-10-01T13:14:46Z

Same here. Additionally, it seems that cargo will stop checking at all if "rust-analyzer.cargo.loadOutDirsFromCheck": true,. (Though that may be more related to the fact my project is large?)
Note I didn't have these options enabled before, but enabling them did not fix this issue for me, it still shows the unresolved imports.

lnicola · 2020-10-01T14:58:29Z

@sunjay

I seem to be getting the unresolved import error for thiserror::Error regardless of whether I have procMacro enabled. I am on rust-analyzer version: nightly (7b674f9).

#5651

Count-Count · 2020-10-03T13:40:24Z

I worked around this issue thus:
use thiserror::*; // should be thiserror::Error, but https://github.com/rust-analyzer/rust-analyzer/issues/6053

0x8f701 · 2020-10-03T16:36:25Z

I'm having similar issue

matklad · 2020-10-14T18:19:45Z

cc @jonas-schievink

jonas-schievink · 2020-10-14T18:44:41Z

They're all working now 🎉 (the procMacro.enable setting can be kept off, we can now resolve proc macro in rust-analyzer itself without consulting Cargo)

teohhanhui · 2020-10-25T10:11:21Z

Now we only need a stable release.

flodiebold · 2020-10-25T10:48:49Z

The fix for this has been included in the last two stable releases, as far as I can see.

teohhanhui · 2020-10-25T11:00:33Z

rust-analyzer version: 2020-10-19 (3ca97b0)

This is still happening to me with things like:

use derivative::Derivative;
use strum_macros::EnumIter;

Is that a separate issue or should this be reopened?

lnicola · 2020-10-25T11:25:34Z

@teohhanhui did you enable build script and proc macro support as in #6053 (comment)?

flodiebold · 2020-10-25T11:39:59Z

strum_macros was mentioned here as well and seems to be related to cfg_attr support, which we already have #5548 for. It'd be worth verifying that for both of these though.

teohhanhui · 2020-10-25T11:45:17Z

@lnicola:

did you enable build script and proc macro support as in #6053 (comment)?

#6053 (comment)

the procMacro.enable setting can be kept off, we can now resolve proc macro in rust-analyzer itself without consulting Cargo

rust-analyzer.cargo.loadOutDirsFromCheck is already set to true.

itmecho · 2020-10-25T20:03:30Z

I'm also getting this error in neovim with the built in lsp client but it's happening on a trait from the std lib rather than an external library. The autocompeltion also seems to not be working for the std::os module.

My nvim_lsp config:

local nvim_lsp = require('nvim_lsp')
local on_attach = function(client)
    require'completion'.on_attach(client)
    require'diagnostic'.on_attach(client)
end

...

nvim_lsp.rust_analyzer.setup{
    on_attach = on_attach;
    settings = {
        ["rust-analyzer"] = {
            cargo = {
                loadOutDirsFromCheck = true;
            }
        }
    }
}

bjorn3 · 2020-10-25T20:17:59Z

That is a duplicate of #6038.

itmecho · 2020-10-25T20:20:54Z

Ah thanks, I'll follow that issue as well

wpbrown · 2020-10-26T01:37:11Z

strum_macros was mentioned here as well and seems to be related to cfg_attr support, which we already have #5548 for. It'd be worth verifying that for both of these though.

Indeed derivative is the same issue. Thanks

#[cfg_attr(not(test), proc_macro_derive(Derivative, attributes(derivative)))]
pub fn derivative(input: TokenStream) -> TokenStream {

hammypants · 2020-12-04T00:43:59Z

This is still happening for the original issue on latest nightly.

Enabling procMacro and cargo.loadOutDirsFromCheck resolves the import, but then all proc macros (that I have tried) fail with proc macro returned error: Server closed.

use thiserror::Error;
..
#[derive(Error, Debug)] // <-- on 'Error': proc macro returned error: Server closed
#[error("{0}")]
struct Foo(String);

bjorn3 · 2020-12-04T07:37:43Z

Which rustc version are you using?

hammypants · 2020-12-05T00:59:21Z

Which rustc version are you using?

rustc 1.46.0 (04488afe3 2020-08-24)

I'll try updating to latest.

EDIT:
Works on latest (and nightly) only with both of the mentioned options above set:

  "rust-analyzer.procMacro.enable": true,
  "rust-analyzer.cargo.loadOutDirsFromCheck": true,

aaomidi · 2021-01-26T23:49:51Z

Not working for me unfortunately.

Settings are on true

➜ rustc --version
rustc 1.51.0-nightly (da305a2b0 2021-01-05)

bjorn3 · 2021-01-27T07:41:05Z

I think there was an abi breaking change on rustc nightly. Either switch to stable or wait for this change to land on stable such that rust-analyzer can adapt to it.

edwin0cheng · 2021-01-27T08:11:37Z

@aaomidi Confirm your bug in rustc-stable,

maybe related to cfg_attr(not(test)...) ?

https://github.com/mcarton/rust-derivative/blob/770c67484a872470ca782202e13fc70a35e2695b/src/lib.rs#L76-L80

#[cfg_attr(not(test), proc_macro_derive(Derivative, attributes(derivative)))]
pub fn derivative(input: TokenStream) -> TokenStream {
    let mut errors = proc_macro2::TokenStream::new();

    let mut output = match syn::parse::<syn::DeriveInput>(input) {
        Ok(parsed) => {
            ast::Input::from_ast(&parsed, &mut errors)
                .map(|mut input| derive_impls(&mut input, &mut errors))
                .unwrap_or_default()
        },
        Err(error) => {
            errors.extend(error.to_compile_error());
            Default::default()
        }
    };

    output.extend(errors);
    output.into()
}

Folaht · 2021-06-04T12:26:31Z

Using LunarVim

rust-ls.lua

require'lspconfig'.rust_analyzer.setup{
    cmd = {DATA_PATH .. "/lspinstall/rust/rust-analyzer"},
    on_attach = require'lsp'.common_on_attach,
    settings = {
        ["rust-analyzer"] = {
	    procMacro = {
	        enable = true
	    },
	    cargo = {
		loadOutDirsFromCheck = true
	    },
        }
    }
}

lnicola · 2021-06-08T08:20:01Z

@Folaht your rustprocMacro key is misspelled (see the manual), but these should be enabled by default in recent versions.

Folaht · 2021-06-08T22:12:35Z

I changed it accordingly. It should be okay now.

OfekShochat · 2021-09-02T19:22:18Z

Im getting this currently with ed25519_dalek

lnicola · 2021-09-10T14:30:05Z

@OfekShochat that's probably #7243

OfekShochat · 2021-09-10T14:58:42Z

yes it is, looked at it

aranw · 2023-07-10T15:31:26Z

I tried to add the suggested fixes above in this issue but I'm still getting the same issue. Is there something else that I am missing?

❯ rustc --version
rustc 1.70.0-nightly (39f2657d1 2023-03-09)

I'm also using rust-analyzer v0.4.1582

ndmitchell mentioned this issue Sep 24, 2020

Option to disable import lens plugin haskell/haskell-language-server#426

Closed

mysteriouspants mentioned this issue Oct 8, 2020

thiserror seems broken (import error) fannheyward/coc-rust-analyzer#407

Closed

lnicola mentioned this issue Oct 9, 2020

derive_more imports not found #6183

Closed

matklad added the E-unknown It's unclear if the issue is E-hard or E-easy without digging in label Oct 14, 2020

matklad added the S-actionable Someone could pick this issue up and work on it right now label Oct 14, 2020

jonas-schievink closed this as completed Oct 14, 2020

edwin0cheng mentioned this issue Jan 27, 2021

Proc-macro derivative::Derivative unresolved #7459

Closed

unresolved import: thiserror::Error #6053

unresolved import: thiserror::Error #6053

Comments

bryanburgers commented Sep 21, 2020

kbleeke commented Sep 21, 2020

bjorn3 commented Sep 21, 2020

Systemcluster commented Sep 21, 2020 • edited Loading

kbleeke commented Sep 21, 2020 • edited Loading

EverlastingBugstopper commented Sep 25, 2020

lnicola commented Sep 25, 2020 • edited Loading

bjorn3 commented Sep 25, 2020

kellpossible commented Sep 29, 2020 • edited Loading

bjorn3 commented Sep 29, 2020

sunjay commented Sep 29, 2020

bjorn3 commented Sep 29, 2020

sunjay commented Sep 29, 2020

Ten0 commented Oct 1, 2020

lnicola commented Oct 1, 2020

Count-Count commented Oct 3, 2020

0x8f701 commented Oct 3, 2020

matklad commented Oct 14, 2020

jonas-schievink commented Oct 14, 2020

teohhanhui commented Oct 25, 2020

flodiebold commented Oct 25, 2020

teohhanhui commented Oct 25, 2020

lnicola commented Oct 25, 2020

flodiebold commented Oct 25, 2020

teohhanhui commented Oct 25, 2020

itmecho commented Oct 25, 2020

bjorn3 commented Oct 25, 2020

itmecho commented Oct 25, 2020

wpbrown commented Oct 26, 2020

hammypants commented Dec 4, 2020 • edited Loading

bjorn3 commented Dec 4, 2020

hammypants commented Dec 5, 2020 • edited Loading

aaomidi commented Jan 26, 2021 • edited Loading

bjorn3 commented Jan 27, 2021

edwin0cheng commented Jan 27, 2021 • edited Loading

Folaht commented Jun 4, 2021 • edited Loading

lnicola commented Jun 8, 2021

Folaht commented Jun 8, 2021

OfekShochat commented Sep 2, 2021 • edited Loading

lnicola commented Sep 10, 2021

OfekShochat commented Sep 10, 2021

aranw commented Jul 10, 2023

unresolved import: `thiserror::Error` #6053

unresolved import: `thiserror::Error` #6053

Systemcluster commented Sep 21, 2020 •

edited

Loading

kbleeke commented Sep 21, 2020 •

edited

Loading

lnicola commented Sep 25, 2020 •

edited

Loading

kellpossible commented Sep 29, 2020 •

edited

Loading

hammypants commented Dec 4, 2020 •

edited

Loading

hammypants commented Dec 5, 2020 •

edited

Loading

aaomidi commented Jan 26, 2021 •

edited

Loading

edwin0cheng commented Jan 27, 2021 •

edited

Loading

Folaht commented Jun 4, 2021 •

edited

Loading

OfekShochat commented Sep 2, 2021 •

edited

Loading