Merge pull request #2294 from strake/if-let-guard

propose if let guard

text/2294-if-let-guard.md

@@ -0,0 +1,169 @@
+- Feature Name: `if_let_guard`
+- Start Date: 2018-01-15
+- RFC PR: [rust-lang/rfcs#2294](https://github.com/rust-lang/rfcs/pull/2294)
+- Rust Issue: [rust-lang/rust#51114](https://github.com/rust-lang/rust/issues/51114)
+
+# Summary
+[summary]: #summary
+
+Allow `if let` guards in `match` expressions.
+
+# Motivation
+[motivation]: #motivation
+
+This feature would greatly simplify some logic where we must match a pattern iff some value computed from the `match`-bound values has a certain form, where said value may be costly or impossible (due to affine semantics) to recompute in the match arm.
+
+For further motivation, see the example in the guide-level explanation. Absent this feature, we might rather write the following:
+```rust
+match ui.wait_event() {
+    KeyPress(mod_, key, datum) =>
+        if let Some(action) = intercept(mod_, key) { act(action, datum) }
+        else { accept!(KeyPress(mod_, key, datum)) /* can't re-use event verbatim if `datum` is non-`Copy` */ }
+    ev => accept!(ev),
+}
+```
+
+`accept` may in general be lengthy and inconvenient to move into another function, for example if it refers to many locals.
+
+Here is an (incomplete) example taken from a real codebase, to respond to ANSI CSI escape sequences:
+
+```rust
+#[inline]
+fn csi_dispatch(&mut self, parms: &[i64], ims: &[u8], ignore: bool, x: char) {
+    match x {
+        'C' => if let &[n] = parms { self.screen.move_x( n as _) }
+               else { log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                                 parms, ims, ignore, x) },
+        'D' => if let &[n] = parms { self.screen.move_x(-n as _) }
+               else { log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                                 parms, ims, ignore, x) },
+        'J' => self.screen.erase(match parms {
+            &[] |
+            &[0] => Erasure::ScreenFromCursor,
+            &[1] => Erasure::ScreenToCursor,
+            &[2] => Erasure::Screen,
+            _ => { log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                              parms, ims, ignore, x); return },
+        }, false),
+        'K' => self.screen.erase(match parms {
+            &[] |
+            &[0] => Erasure::LineFromCursor,
+            &[1] => Erasure::LineToCursor,
+            &[2] => Erasure::Line,
+            _ => { log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                              parms, ims, ignore, x); return },
+        }, false),
+        'm' => match parms {
+            &[] |
+            &[0] => *self.screen.def_attr_mut() = Attr { fg_code: 0, fg_rgb: [0xFF; 3],
+                                                         bg_code: 0, bg_rgb: [0x00; 3],
+                                                         flags: AttrFlags::empty() },
+            &[n] => if let (3, Some(rgb)) = (n / 10, color_for_code(n % 10, 0xFF)) {
+                self.screen.def_attr_mut().fg_rgb = rgb;
+            } else {
+                log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                           parms, ims, ignore, x);
+            },
+            _ => log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                            parms, ims, ignore, x),
+        },
+        _ => log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                        parms, ims, ignore, x),
+    }
+}
+```
+
+These examples are both clearer with `if let` guards as follows. Particularly in the latter example, in the author's opinion, the control flow is easier to follow.
+
+# Guide-level explanation
+[guide-level-explanation]: #guide-level-explanation
+
+*(Adapted from Rust book)*
+
+A *match guard* is an `if let` condition specified after the pattern in a `match` arm that also must match if the pattern matches in order for that arm to be chosen. Match guards are useful for expressing more complex ideas than a pattern alone allows.
+
+The condition can use variables created in the pattern, and the match arm can use any variables bound in the `if let` pattern (as well as any bound in the `match` pattern, unless the `if let` expression moves out of them).
+
+Let us consider an example which accepts a user-interface event (e.g. key press, pointer motion) and follows 1 of 2 paths: either we intercept it and take some action or deal with it normally (whatever that might mean here):
+```rust
+match ui.wait_event() {
+    KeyPress(mod_, key, datum) if let Some(action) = intercept(mod_, key) => act(action, datum),
+    ev => accept!(ev),
+}
+```
+
+Here is another example, to respond to ANSI CSI escape sequences:
+
+```rust
+#[inline]
+fn csi_dispatch(&mut self, parms: &[i64], ims: &[u8], ignore: bool, x: char) {
+    match x {
+        'C' if let &[n] = parms => self.screen.move_x( n as _),
+        'D' if let &[n] = parms => self.screen.move_x(-n as _),
+        _ if let Some(e) = erasure(x, parms) => self.screen.erase(e, false),
+        'm' => match parms {
+            &[] |
+            &[0] => *self.screen.def_attr_mut() = Attr { fg_code: 0, fg_rgb: [0xFF; 3],
+                                                         bg_code: 0, bg_rgb: [0x00; 3],
+                                                         flags: AttrFlags::empty() },
+            &[n] if let (3, Some(rgb)) = (n / 10, color_for_code(n % 10, 0xFF)) =>
+                self.screen.def_attr_mut().fg_rgb = rgb,
+            _ => log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                            parms, ims, ignore, x),
+        },
+        _ => log_debug!("Unknown CSI sequence: {:?}, {:?}, {:?}, {:?}",
+                        parms, ims, ignore, x),
+    }
+}
+
+#[inline]
+fn erasure(x: char, parms: &[i64]) -> Option<Erasure> {
+    match x {
+        'J' => match parms {
+            &[] |
+            &[0] => Some(Erasure::ScreenFromCursor),
+            &[1] => Some(Erasure::ScreenToCursor),
+            &[2] => Some(Erasure::Screen),
+            _ => None,
+        },
+        'K' => match parms {
+            &[] |
+            &[0] => Some(Erasure::LineFromCursor),
+            &[1] => Some(Erasure::LineToCursor),
+            &[2] => Some(Erasure::Line),
+            _ => None,
+        },
+        _ => None,
+    }
+}
+```
+
+
+# Reference-level explanation
+[reference-level-explanation]: #reference-level-explanation
+
+This proposal would introduce syntax for a match arm: `pat if let guard_pat = guard_expr => body_expr` with semantics so the arm is chosen iff the argument of `match` matches `pat` and `guard_expr` matches `guard_pat`. The variables of `pat` are bound in `guard_expr`, and the variables of `pat` and `guard_pat` are bound in `body_expr`. The syntax is otherwise the same as for `if` guards. (Indeed, `if` guards become effectively syntactic sugar for `if let` guards.)
+
+An arm may not have both an `if` and an `if let` guard.
+
+# Drawbacks
+[drawbacks]: #drawbacks
+
+* It further complicates the grammar.
+* It is ultimately syntactic sugar, but the transformation to present Rust is potentially non-obvious.
+
+# Rationale and alternatives
+[alternatives]: #alternatives
+
+* The chief alternatives are to rewrite the guard as an `if` guard and a bind in the match arm, or in some cases into the argument of `match`; or to write the `if let` in the match arm and copy the rest of the `match` into the `else` branch — what can be done with this syntax can already be done in Rust (to the author's knowledge); this proposal is purely ergonomic, but in the author's opinion, the ergonomic win is significant.
+* The proposed syntax feels natural by analogy to the `if` guard syntax we already have, as between `if` and `if let` expressions. No alternative syntaxes were considered.
+
+# Unresolved questions
+[unresolved]: #unresolved-questions
+
+Questions in scope of this proposal: none yet known
+
+Questions out of scope:
+
+* Should we allow multiple guards? This proposal allows only a single `if let` guard. One can combine `if` guards with `&&` — [an RFC](https://github.com/rust-lang/rfcs/issues/929) to allow `&&` in `if let` already is, so we may want to follow that in future for `if let` guards also.
+* What happens if `guard_expr` moves out of `pat` but fails to match? This is already a question for `if` guards and (to the author's knowledge) not formally specified anywhere — this proposal (implicitly) copies that behavior.