Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary the const_fn feature gate #321

Merged
merged 1 commit into from
May 12, 2021

Conversation

JohnTitor
Copy link
Member

Fixes #320, caused by rust-lang/rust#85109
This exists since 1596d1b#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R2 but now it's unnecessary as all the use here should be stabilized now.

@JohnTitor
Copy link
Member Author

CI failure is unrelated:

error: dereferencing a null pointer
 --> /home/travis/build/rust-lang/packed_simd/examples/target/release/build/aobench-a0b4f4b850beb8cb/out/aobench.rs:5:6095
  |
5 | ... ! ( unsafe { & ( * ( :: std :: ptr :: null :: < __fsid_t > ( ) ) ) . __val as * const _ as usize } , 0usize , concat ! ( "Offset of f...
  |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed
  |
note: the lint level is defined here
 --> aobench/src/lib.rs:5:9
  |
5 | #![deny(warnings, rust_2018_idioms)]
  |         ^^^^^^^^
  = note: `#[deny(deref_nullptr)]` implied by `#[deny(warnings)]`

error: aborting due to previous error

@workingjubilee workingjubilee merged commit cf07679 into rust-lang:master May 12, 2021
@JohnTitor JohnTitor deleted the fix-build branch May 12, 2021 16:33
@JohnTitor
Copy link
Member Author

@workingjubilee Usually, do we publish a new version for such a case? Since the feature flag breaks the build, it may be worth doing so.

@workingjubilee
Copy link
Member

Yeah, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packed_simd build fails with Rust nightly
2 participants