Don't quote absolute path helper commands #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoting treats the full command as the path to binary, which prevents arguments from being provided. According to the [Git documentation][git-docs] arguments should be accepted. This also [matches the behaviour][git-source] of git itself. [git-docs]: https://git-scm.com/docs/api-credentials#_credential_helpers [git-source]: https://github.com/git/git/blob/ca1b4116483b397e78483376296bcd23916ab553/credential.c#L258-L261
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting treats the full command as the path to binary, which prevents arguments from being provided.
According to the Git documentation arguments should be accepted. This also matches the behaviour of git itself.
I discovered this issue through Cargo's use of this library.