Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust warning for rustdoc filename collision. #7244

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 13, 2019

The existing warning was a little misleading, as this is a known bug, not something we currently plan to reject.

cc #6313 (comment)

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 13, 2019

📌 Commit 5d98fca has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2019
@bors
Copy link
Contributor

bors commented Aug 13, 2019

⌛ Testing commit 5d98fca with merge efba16d893e8996486cb4ee027d6d2f7b582a1c7...

@bors
Copy link
Contributor

bors commented Aug 13, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Aug 13, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2019
@bors
Copy link
Contributor

bors commented Aug 13, 2019

⌛ Testing commit 5d98fca with merge d19f614...

bors added a commit that referenced this pull request Aug 13, 2019
Adjust warning for rustdoc filename collision.

The existing warning was a little misleading, as this is a known bug, not something we currently plan to reject.

cc #6313 (comment)
@bors
Copy link
Contributor

bors commented Aug 13, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing d19f614 to master...

@bors bors merged commit 5d98fca into rust-lang:master Aug 13, 2019
@ehuss ehuss added this to the 1.39.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants