-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update proptest #11886
Merged
Merged
Update proptest #11886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
cc @Eh2406 If you want to review. |
@bors r+ |
☀️ Test successful - checks-actions |
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Mar 27, 2023
9 commits in 15d090969743630bff549a1b068bcaa8174e5ee3..145219a9f089f8b57c09f40525374fbade1e34ae 2023-03-21 17:54:28 +0000 to 2023-03-27 01:56:36 +0000 - doc(contrib): missing quotation mark (rust-lang/cargo#11894) - Update changelog for 1.68.2 (rust-lang/cargo#11893) - Add the old github keys as revoked (rust-lang/cargo#11889) - Update proptest (rust-lang/cargo#11886) - Added new GitHub RSA Host Key (rust-lang/cargo#11883) - doc: Fix registries.name.index for sparse (rust-lang/cargo#11880) - docs(contrib): Replace architecture with redirects (rust-lang/cargo#11876) - docs: fix typos in `cargo_compile/mod.rs` (rust-lang/cargo#11874) - docs(contrub): Remove unused file (rust-lang/cargo#11873)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 27, 2023
Update cargo 9 commits in 15d090969743630bff549a1b068bcaa8174e5ee3..145219a9f089f8b57c09f40525374fbade1e34ae 2023-03-21 17:54:28 +0000 to 2023-03-27 01:56:36 +0000 - doc(contrib): missing quotation mark (rust-lang/cargo#11894) - Update changelog for 1.68.2 (rust-lang/cargo#11893) - Add the old github keys as revoked (rust-lang/cargo#11889) - Update proptest (rust-lang/cargo#11886) - Added new GitHub RSA Host Key (rust-lang/cargo#11883) - doc: Fix registries.name.index for sparse (rust-lang/cargo#11880) - docs(contrib): Replace architecture with redirects (rust-lang/cargo#11876) - docs: fix typos in `cargo_compile/mod.rs` (rust-lang/cargo#11874) - docs(contrub): Remove unused file (rust-lang/cargo#11873) r? `@ghost`
bors
added a commit
that referenced
this pull request
Apr 15, 2023
Make cargo a workspace ### What does this PR try to resolve? The first step of making cargo a workspace. Benefits: * Dogfooding ourselves. * Unblock #11831: It got stuck because the new version of tempfile using `windows-sys` but some issues haven't yet be solved in rust-lang/rust. * Make `cargo xtask` or similar developer workflow possible (e.g., #11717) * Having our own Cargo.lock, so our CI can cover the exact binary going to ship. Also free Cargo from CI breaks due to dependency patch releases. * Probably more? Please add them by yourself. ### How should we test and review this PR? Please review it commit by commit. A companion PR is here rust-lang/rust#109133, and should be reviewed together. ### Unresolved issues To limit the scope of this pull request, the following issues are intentionally left unresolved. They will be addressed right after this pull request gets merged. - [x] Make `benches/capture` and `benches/capture` workspace members. (Addressed with 2cf9718) - [x] Make `crates/resolver-tests` a workspace member. (Addressed with #11886) - [ ] ~~Fix clippy warnings and re-enable clippy check in CI for all workspace members.~~ - Blocked on rust-lang/rfcs#3389 so we can more easily propagate our clippy settings - [ ] Fix rustdoc warnings and re-enable rustdoc check in CI for all workspace members. - [ ] Fix `linkchecker.sh` warnings in CI (#11851 (comment)) - [ ] Leverage workspace flag `--workspace` when running `cargo build` or `cargo test`, instead of using flag `-p`. - [ ] Leverage glob syntax when probing members in `[workspace]` in Cargo.toml (i.e., `crates/*`). ### Additional information This depends on prior works from `@Muscraft` and `@ehuss.` Credits to them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dependency-resolution
Area: dependency resolution and the resolver
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates proptest from 0.9.1 to 1.1.0. This helps drop some old, unsupported dependencies like
fuchsia-cprng
from an old version ofrand
.Changelog: https://github.com/proptest-rs/proptest/blob/master/proptest/CHANGELOG.md
I don't see any particularly relevant breaking changes for our use.