-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo nightly no longer working #4189
Comments
I tried uninstalling and reinstalling rustup to see if there was something that got goofed there, but seeing the same issue. |
I'm getting the same thing here. |
I am not sure about the new issue, may be all these problems caused by single bug. Cargo messages are broken too on nightly (messed newlines):
|
It looks like Cargo's doing things it's just not printing to the console, probably related to #4162. When run directly (not through rustup) I see messages getting printed out. @K-Finlay I can't confirm that @pravic I cannot reproduce the interleaving you're seeing, can you provide details on the versions used and how to reproduce? |
cargo 0.21.0-nightly (e53e2f8d5 2017-06-17) Windows 7 x64 SP1, ConEmu 170118 (without ConEmu almost the same behavior).
Nightly:
Stable:
Direct (no output at all):
|
@pravic for the direct invocation was that with with a removed |
The primary motivation for this commit was rust-lang/cargo#4189 where dropping a `wincolor::Console` would call `CloseHandle` to close the console handle. Cargo creates a few `Console` instances so it ended up closing stdout a little earlier as intended! The `GetStdHandle` function returns handles I believe aren't intended to be closed (as there's no refcounting). I believe libstd doesn't close these handles. This commit also moves to calling `GetStdHandle` on demand which libstd changed to doing so recently as well, preventing caching of stale handles that change over time with calls to `SetStdHandle`.
I believe this is fixed by BurntSushi/ripgrep#523 after looking into it a bit, or at least it fixes a number of issues for me locally. I think rustup was a red herring. |
Yes, it was after |
The primary motivation for this commit was rust-lang/cargo#4189 where dropping a `wincolor::Console` would call `CloseHandle` to close the console handle. Cargo creates a few `Console` instances so it ended up closing stdout a little earlier as intended! The `GetStdHandle` function returns handles I believe aren't intended to be closed (as there's no refcounting). I believe libstd doesn't close these handles. This commit also moves to calling `GetStdHandle` on demand which libstd changed to doing so recently as well, preventing caching of stale handles that change over time with calls to `SetStdHandle`.
Helps mitigate rust-lang#4189
I'm getting what appears to be similar issues with nightly right now. |
@alexcrichton "cargo new" failing seems to be an error on my end. |
Update `wincolor` dep for Cargo Closes rust-lang/cargo#4189
On windows it same with nightly. Piping errors to file helps: |
This was with the most recent rustup'ing of nightly:
It seems like cargo just hangs there, showing no status. It does "finish" but I don't see the build artefact I'd expect. "cargo run" also doesn't work correctly, returning to the cmd line with no message instead of running the application.
The text was updated successfully, but these errors were encountered: