Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the Either parser #1821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose the Either parser #1821

wants to merge 1 commit into from

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Feb 8, 2025

This will make it easier to build Parser implementations without having to implement the trait manually

This will make it easier to build Parser implementations without having
to implement the trait manually
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.42%. Comparing base (a44b52e) to head (5534e57).

Files with missing lines Patch % Lines
benchmarks/benches/json.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
+ Coverage   61.34%   61.42%   +0.07%     
==========================================
  Files          26       26              
  Lines        3128     3124       -4     
==========================================
  Hits         1919     1919              
+ Misses       1209     1205       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 8, 2025

CodSpeed Performance Report

Merging #1821 will improve performances by 13.57%

Comparing either-parser (5534e57) with main (a44b52e)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
number 244.2 ns 215 ns +13.57%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant