Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename method for nested workflows to add_workflows #15596

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

logan-markewich
Copy link
Collaborator

Renames add_services() to add_workflows() since for now, this only works for workflows

Keeps the underlying service manager and related code since it is generally useful

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 23, 2024
Copy link
Member

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2024
@logan-markewich logan-markewich merged commit 3a125f6 into main Aug 23, 2024
8 checks passed
@logan-markewich logan-markewich deleted the logan/rename_nested_workflows branch August 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants