Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly support disable_control_plane in deploy() function #437

Merged
merged 10 commits into from
Jan 24, 2025
Merged

fix: properly support disable_control_plane in deploy() function #437

merged 10 commits into from
Jan 24, 2025

Conversation

masci
Copy link
Member

@masci masci commented Jan 23, 2025 •
edited
Loading

Fixes #435

Also in this PR:

  • Split e2e tests by package. As we add more e2e tests the flakyness is increasing, and it's extremely difficult to debug since tests pass locally. By splitting the e2e tests by package we reduce the load of process and coroutine orchestration for each run and we also increase parallelism (with the new layout e2e tests pass in about 2 minutes on Github workflows)

@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Coverage Status

coverage: 77.835% (+0.2%) from 77.68%
when pulling d921736 on massi/435
into 8722c8a on main.

@masci masci requested a review from logan-markewich January 23, 2025 17:23
@masci masci merged commit 59b23d3 into main Jan 24, 2025
31 checks passed
@masci masci deleted the massi/435 branch January 24, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich Awaiting requested review from logan-markewich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running deploy_core with disable_control_plane fails
2 participants
@masci @coveralls