Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cluttering logs with simple message queue polling #429

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

masci
Copy link
Member

@masci masci commented Jan 16, 2025

Fixes #428

After the refactoring, the SimpleMessageQueue behaves like a pubsub system with the client polling for messages, similar to Redis for example. Using plain HTTP calls as the pubsub protocol, the client keeps GETting the endpoint on the server to get messages (if any) for the whole application lifetime, and uvicorn happily fills the access logs with noise.

This PR filters out polling requests to the /messages endpoint from the access logs.

@coveralls
Copy link

Coverage Status

coverage: 77.68% (+0.04%) from 77.638%
when pulling dfd57cf on massi/simplemessage-logs
into 26b8ad5 on main.

@logan-markewich logan-markewich merged commit d783df9 into main Jan 16, 2025
10 checks passed
@logan-markewich logan-markewich deleted the massi/simplemessage-logs branch January 16, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Deploying a workflow results in endless pings between services
3 participants