Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to thiserror 2.0.4 where possible #18761

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 commented Nov 26, 2024

Our "jpegxr" crate is still to be updated, because it doesn't have Dependabot set up.
EDIT: Done.

@torokati44 torokati44 added A-deps Area: Dependencies T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 26, 2024
@torokati44
Copy link
Member Author

torokati44 commented Nov 26, 2024

See: ruffle-rs/jpegxr#4
EDIT: Merged.

@torokati44
Copy link
Member Author

Uh, the CI failure seems to be bogus...?
https://github.com/ruffle-rs/ruffle/actions/runs/12021815997/job/33512985856?pr=18761#step:6:1096

error: the following explicit lifetimes could be elided: 'gc
 --> core/src/avm1/error.rs:5:16
  |
5 | pub enum Error<'gc> {
  |                ^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
  = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
  |
5 - pub enum Error<'gc> {
5 + pub enum Error'_> {
  |

See: rust-lang/rust-clippy#12789 and/or rust-lang/rust-clippy#12908.

@torokati44 torokati44 force-pushed the thiserror-2 branch 2 times, most recently from 1d33429 to e8f79f5 Compare November 27, 2024 17:46
@torokati44 torokati44 force-pushed the thiserror-2 branch 2 times, most recently from c35c02c to 90e4b67 Compare December 2, 2024 23:10
@torokati44 torokati44 changed the title chore: Switch to thiserror 2.0.3 where possible chore: Switch to thiserror 2.0.4 where possible Dec 4, 2024
@torokati44
Copy link
Member Author

The beta clippy lint got fixed by dtolnay/thiserror#391 in 2.0.4, it no longer has to be suppressed.

@torokati44 torokati44 added the waiting-on-review Waiting on review from a Ruffle team member label Dec 4, 2024
@Dinnerbone Dinnerbone enabled auto-merge (rebase) December 5, 2024 18:54
@Dinnerbone Dinnerbone merged commit ac8ad5c into ruffle-rs:master Dec 5, 2024
22 checks passed
@Lord-McSweeney Lord-McSweeney removed the waiting-on-review Waiting on review from a Ruffle team member label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Dependencies T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants