-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Handle] Add support for booleans in the handles #2065
base: master
Are you sure you want to change the base?
[Handle] Add support for booleans in the handles #2065
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 89.59% 89.52% -0.07%
==========================================
Files 139 139
Lines 15222 15275 +53
Branches 1290 1292 +2
==========================================
+ Hits 13638 13675 +37
- Misses 1096 1109 +13
- Partials 488 491 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks very nice! Is this ready to be used by hardware components now? how?
@christophfroehlich Yes, it is ready to be used. When you export interfaces from your hardware, just create an Interface with the However, the following Hardware component API needs to be refined. I added the discussion to the next WG meeting. If you can access the interface, then you should be able to set the data and retrieve the data. ros2_control/hardware_interface/include/hardware_interface/system_interface.hpp Lines 517 to 535 in 201d3a7
|
4f8dc58
to
9e27272
Compare
This PR aims to add support for boolean types in the Handle using the internal variant. The data_type is selected using the
InterfaceInfo
information.