-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transmissions] Make transmission interface work with new variants approach #1845
Open
saikishor
wants to merge
8
commits into
ros-controls:master
Choose a base branch
from
pal-robotics-forks:fix/transmissions/variants
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Transmissions] Make transmission interface work with new variants approach #1845
saikishor
wants to merge
8
commits into
ros-controls:master
from
pal-robotics-forks:fix/transmissions/variants
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
- Coverage 89.59% 89.46% -0.14%
==========================================
Files 139 139
Lines 15222 15408 +186
Branches 1290 1298 +8
==========================================
+ Hits 13638 13784 +146
- Misses 1096 1132 +36
- Partials 488 492 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new changes to the handles, that the data exists inside the Handle itself will create problems with the old transmission_interface API and it is kinda dysfunctional with the new approach. This PR aims to solve the issue by migrating the transmission part to the new API and making it functional with the latest shared pointers approach.