Addressed code review comments

romannurik · Nov 5, 2024 · 7cf9548 · 7cf9548
1 parent 802432c
commit 7cf9548
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/main.tsx b/src/main.tsx
@@ -21,16 +21,16 @@ import { ConfigWrapper } from "./Config.tsx";
 import "./index.scss";
 import { AppStateWrapper } from "./AppState.tsx";
 
-if('serviceWorker' in navigator){
-  navigator.serviceWorker.register('/sw.js', {
-    scope: '/'
-  }).then((register) => {
-    console.log('service worker registered', register)
-  })
-  .catch((err) => {
-    console.log('service worker not registered', err)
-  })
-}
+window.addEventListener('load', async () => {
+  try{
+    if(navigator.serviceWorker){
+      await navigator.serviceWorker.register('/sw.js')
+    }
+  }
+  catch(err){
+    // log error
+  }
+})
 
 ReactDOM.createRoot(document.getElementById("root")!).render(
   <React.StrictMode>

diff --git a/vite.config.ts b/vite.config.ts
@@ -51,4 +51,4 @@ const manifestForPlugin: Partial<VitePWAOptions> = {
 export default defineConfig({
   plugins: [react(), VitePWA(manifestForPlugin)],
   base: "",
-});
+});