Allow GTM override #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrolldepth currently assumes that if GTM is on the page it is used to implement Google Analytics. This does not have to be the case and should be configurable.
|
Yes, I believe I have this scenario as well and just heard a complaint. Will be testing this. |
|
Thanks for catching this. I wonder if there's a way to do this without requiring a plugin option, i.e. is it possible to detect whether GA is implemented via GTM? |
|
Not that I know of, unfortunately, or that would obviously be a better solution. You could try to do some inferential stuff like checking whether there is onpage code for GA and whether GTM is also initialized on the page, but that will still create edge cases where you have a non-standard GA implementation if the best you can do is correlate the two. |
|
@bmd Merged into master. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this fix for a recent project, so I thought it might be worth committing back.
While analytics is often implemented through GTM, this isn't necessarily the case, and the current version doesn't work on pages where GTM is included but doesn't implement GA.