fix make csi-sp test #120
Merged
fix make csi-sp test #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing `make csi-sp`, we should always use the Gopkg.toml file from the checked out source. The current test was failing because once CSI v1.1.0 was released, the Gopkg.toml file that was created by gocsi.sh wasn't identical to the one in the repo. Furthermore, we also needed change the version spec to use "=" to lock it down. Without the "=", the syntax actually defaults to "^", which if using "v1.0.0" means using anything from 1.0.0 to <2.0.0. So we were pulling in the latest spec when we really wanted to be on 1.0.0 exactly. Travis-CI Go version is bumpted to solve a DisallowUnknownFields support issue for YAML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #119
This is a touch hacky, but I'm changing it as part of a subsequent PR to move to Go modules anyways. The
make csi-sptest was failing because it was pulling in the latest CSI spec, rather than the one we had specified in the Gopkg.toml file. This wasn't an issue until code went in for CSI v1.1.0 that added new methods to the CSI controller interface. I think it is completely fair that for CI, makefile originated runs of csi-sp test, that we always use theGopkg.tomlfile from the checked out version of the code. So I took advantage of a switch withingocsi.shthat doesn't write a newGopkg.tomlfile if it already exists -- I had the Makefile just copy it directly.When doing
make csi-sp, we should always use the Gopkg.toml file fromthe checked out source. The current test was failing because once CSI
v1.1.0 was released, the Gopkg.toml file that was created by gocsi.sh
wasn't identical to the one in the repo. Furthermore, we also needed
change the version spec to use "=" to lock it down. Without the "=", the
syntax actually defaults to "^", which if using "v1.0.0" means using
anything from 1.0.0 to <2.0.0. So we were pulling in the latest spec
when we really wanted to be on 1.0.0 exactly.
Travis-CI Go version is bumped to solve a
DisallowUnknownFieldssupportissue for YAML.