feat(#1007): implement backing component #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jshen123
commented
Jul 10, 2023
| @@ -19,6 +19,11 @@ const config = { | |||
| poll: 1000, | |||
| aggregateTimeout: 300 | |||
| }; | |||
| config.module.rules.push({ | |||
There was a problem hiding this comment.
leverage SVGR (to transform svgs into react components)
https://react-svgr.com/
There was a problem hiding this comment.
Whats the motivation for SVGR? Can't we just load them as SVG?
|
Hi 👋 We couldn't create a preview environment for this pull-request 😥 You can see your environment build logs here. Please double-check your If you need help, email us at [email protected] or join Discord. Click here to disable Ergomake. |
package.json
Outdated
Comment on lines
1
to
5
| { | ||
| "devDependencies": { | ||
| "@svgr/webpack": "^8.0.1" | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you accidentally placed this and the lock file in the root of the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1007