add rustc-dep-of-std feature #831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit paves the way for libstd to depend on winapi and crates that depend on winapi.
|
This PR fails to build on Rust 1.6 due to cargo changes so this may have to be delayed until winapi 0.4. |
|
@retep998 Do you have an idea of what features you'd like to include in a 0.4 release? It would be helpful to have a tracking issue. I'm happy to help push that forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit paves the way for libstd to depend on winapi and crates that
depend on winapi.
Tested with a local build of libstd on both
-msvcand-gnutargets.While it's possible to move small parts of libstd to winapi with this commit, it will be tricky to do a large-scale refactor until #771 and #323 are addressed.