Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CA): adding USDS asset support #981

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Mar 6, 2025

Description

This PR adds USDS (DAI) asset support for the chain abstraction on Optimism and Arbitrum chains.
Since the bridging fee for DAI is very low, increasing the bridging fee slippage from 75% to 200% will avoid bridging transactions failing in case of fee fluctuation.

How Has This Been Tested?

  • A new integration test was created.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Mar 6, 2025
@geekbrother geekbrother force-pushed the feat/add_usds_support branch from 3aca68f to 3942561 Compare March 6, 2025 12:18
@@ -23,7 +23,7 @@ pub mod route;
pub mod status;

/// How much to multiply the bridging fee amount to cover bridging fee volatility
pub const BRIDGING_FEE_SLIPPAGE: i8 = 75; // 75%
pub const BRIDGING_FEE_SLIPPAGE: i16 = 200; // 200%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the bridging fee for DAI is very low, increasing the slippage to avoid bridging transaction failing in case of the fee fluctuation.

@geekbrother geekbrother marked this pull request as ready for review March 6, 2025 12:22
@geekbrother geekbrother merged commit 00c1106 into master Mar 6, 2025
30 of 39 checks passed
@geekbrother geekbrother deleted the feat/add_usds_support branch March 6, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants