-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release date #5960
feat: release date #5960
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,6 @@ export const defaultConfig = { | |
versioning: npmVersioning.id, | ||
prBodyDefinitions: { | ||
Change: | ||
"[{{#if displayFrom}}`{{{displayFrom}}}` -> {{else}}{{#if currentValue}}`{{{currentValue}}}` -> {{/if}}{{/if}}{{#if displayTo}}`{{{displayTo}}}`{{else}}`{{{newValue}}}`{{/if}}](https://renovatebot.com/diffs/npm/{{replace '/' '%2f' depName}}/{{{fromVersion}}}/{{{toVersion}}})", | ||
"[{{#if displayFrom}}`{{{displayFrom}}}` -> {{else}}{{#if currentValue}}`{{{currentValue}}}` -> {{/if}}{{/if}}{{#if displayTo}}`{{{displayTo}}}`{{else}}`{{{newValue}}}`{{/if}}](https://renovatebot.com/diffs/npm/{{replace '/' '%2f' depName}}/{{{fromVersion}}}/{{{toVersion}}}) {{#if releaseTimestamp}}({{{releaseTimestamp}}}){{/if}}", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. revert this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. okay |
||
}, | ||
}; |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -44,6 +44,7 @@ export const allowedFields = { | |||||
depType: 'The dependency type (if extracted - manager-dependent)', | ||||||
displayFrom: 'The current value, formatted for display', | ||||||
displayTo: 'The to value, formatted for display', | ||||||
releaseTimestamp: 'The release timeStamp of the newer version', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
fromVersion: | ||||||
'The version that would be currently installed. For example, if currentValue is ^3.0.0 then currentVersion might be 3.1.0.', | ||||||
isLockfileUpdate: 'true if the branch is a lock file update', | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ import { getControls } from './controls'; | |
import { BranchConfig } from '../../common'; | ||
|
||
function massageUpdateMetadata(config: BranchConfig): void { | ||
config.upgrades.forEach((upgrade) => { | ||
config.upgrades.forEach(upgrade => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update your |
||
/* eslint-disable no-param-reassign */ | ||
const { homepage, sourceUrl, sourceDirectory, changelogUrl } = upgrade; | ||
let depNameLinked = upgrade.depName; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ function getTableDefinition(config: BranchConfig): TableDefinition[] { | |
const value = config.prBodyDefinitions[header]; | ||
res.push({ header, value }); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. revert all changes in this file |
||
return res; | ||
} | ||
|
||
|
@@ -36,7 +37,7 @@ function getNonEmptyColumns( | |
|
||
export function getPrUpdatesTable(config: BranchConfig): string { | ||
const tableDefinitions = getTableDefinition(config); | ||
const tableValues = config.upgrades.map((upgrade) => { | ||
const tableValues = config.upgrades.map(upgrade => { | ||
const res: Record<string, string> = {}; | ||
for (const column of tableDefinitions) { | ||
const { header, value } = column; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure