fix(pr): wrong release notes when releases found in URLs #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BEFORE |
|
Needs at least one test added. Should be one that fails on master but passes one this branch. |
rarkins
requested changes
Mar 29, 2020
rarkins
reviewed
Mar 29, 2020
rarkins
requested changes
Mar 29, 2020
ViralRuparel
force-pushed
the
fix/wrong-release-notes
branch
from
59fc5aa to
8113095
Compare
|
In master branch: |
rarkins
requested changes
Mar 29, 2020
rarkins
changed the title
|
🎉 This PR is included in version 19.188.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of wrong release notes in PR body. Issue occurred when the CHANGELOG.md had an url linked with the version, due to which it had matching version two times, one in the actual version
[v3.0.3]and another was when it had version number in the link url eg.(https://github.com/npm/hosted-git-info/compare/v3.0.3...v3.0.4)Closes #4618