Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for standard-version changelog #5183

Conversation

simoneb
Copy link

@simoneb simoneb commented Jan 17, 2020

WIP

Add a test that release notes from the standard-version package CHANGELOG are parsed correctly.

Discussed in #5181

@rarkins
Copy link
Collaborator

rarkins commented Jan 17, 2020

  • test both 7.0.0 and 7.0.1
  • verify that 7.0.0 doesn't contain 7.0.1 inside it
  • verity that 7.0.1 has the expected content (e.g. a Bug Fixes header)

@simoneb
Copy link
Author

simoneb commented Jan 17, 2020

@rarkins done and all passing. I'm confused! By looking at the snapshot I get a feeling that what the parser produces is not correct, but I'm not sure how to write a failing test because I'm not quite sure what I should expect it to produce

@simoneb simoneb force-pushed the feat/standard-version-changelog-support branch from 127ef73 to 537f631 Compare January 17, 2020 18:58
@simoneb simoneb force-pushed the feat/standard-version-changelog-support branch from 537f631 to 42171fb Compare January 17, 2020 19:05
@rarkins rarkins merged commit ef15f01 into renovatebot:feat/standard-version-changelog-support Jan 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants