fix: optimize type checks (#34654)

renovatebot · Mar 6, 2025 · b9484f1 · b9484f1
1 parent d300cd0
commit b9484f1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/lib/config/migrations/custom/rebase-stale-prs-migration.ts b/lib/config/migrations/custom/rebase-stale-prs-migration.ts
@@ -16,7 +16,7 @@ export class RebaseStalePrsMigration extends AbstractMigration {
         );
       }
 
-      if (is.null_(value)) {
+      if (null === value) {
         this.setSafely('rebaseWhen', 'auto');
       }
     }

diff --git a/lib/config/validation.ts b/lib/config/validation.ts
@@ -677,7 +677,7 @@ export async function validateConfig(
                   });
                 }
                 if (
-                  !(is.string(statusCheckValue) || is.null_(statusCheckValue))
+                  !(is.string(statusCheckValue) || null === statusCheckValue)
                 ) {
                   errors.push({
                     topic: 'Configuration Error',

diff --git a/lib/modules/manager/bundler/artifacts.ts b/lib/modules/manager/bundler/artifacts.ts
@@ -85,7 +85,7 @@ export async function updateArtifacts(
     return null;
   }
 
-  const updatedDepNames = updatedDeps
+  const updatedDepNames: string[] = updatedDeps
     .map(({ depName }) => depName)
     .filter(is.nonEmptyStringAndNotWhitespace);
 

diff --git a/lib/modules/manager/mise/extract.ts b/lib/modules/manager/mise/extract.ts
@@ -45,7 +45,7 @@ function parseVersion(toolData: MiseToolSchema): string | null {
     // e.g. 'erlang = ["23.3", "24.0"]'
     return toolData.length ? toolData[0] : null; // Get the first version in the array
   }
-  if (is.nonEmptyString(toolData.version)) {
+  if (is.object(toolData) && is.nonEmptyString(toolData.version)) {
     // Handle the object case with a string version
     // e.g. 'python = { version = "3.11.2" }'
     return toolData.version;

diff --git a/lib/workers/repository/onboarding/pr/config-description.ts b/lib/workers/repository/onboarding/pr/config-description.ts
@@ -25,7 +25,9 @@ export function getScheduleDesc(config: RenovateConfig): string[] {
 function getDescriptionArray(config: RenovateConfig): string[] {
   logger.debug('getDescriptionArray()');
   logger.trace({ config });
-  const desc = is.nonEmptyArray(config.description) ? config.description : [];
+  const desc = is.array(config.description, is.string)
+    ? config.description
+    : [];
   return desc.concat(getScheduleDesc(config));
 }
-Original file line number
+Diff line change
@@ Expand Up @@
             );
           }
-          if (is.null_(value)) {
+          if (null === value) {
             this.setSafely('rebaseWhen', 'auto');
           }
         }
@@ Expand Down @@