🎨 refactor: update .gitignore and remove redundant closed fields (main)

- Added `.vscode/` to .gitignore to ignore Visual Studio Code settings.
- Removed redundant `closed` fields and associated checks in HTTPFetcher and JinaFetcher.
- Updated `BrowserControlUrl` in Config struct to use `envDefault` for default value.

.gitignore

@@ -50,4 +50,5 @@ _testmain.go
 # This file includes artifacts of Go build that should not be checked in.
 # For files created by specific development environment (e.g. editor),
 # use alternative ways to exclude files from git.
-# For example, set up .git/info/exclude or use a global .gitignore.
+# For example, set up .git/info/exclude or use a global .gitignore.
+.vscode/

internal/pkg/config/config.go

@@ -82,10 +82,10 @@ type Config struct {
 	OAuths    struct {
 		Github OAuthConfig `envPrefix:"GITHUB_"`
 	} `envPrefix:"OAUTH_"`
-	OpenAI                OpenAIConfig       `envPrefix:"OPENAI_"`
-	GoogleSearch          GoogleSearchConfig `envPrefix:"GOOGLE_SEARCH_"`
-	S3                    S3Config           `envPrefix:"S3_"`
-	BrowserlessControlUrl string             `env:"BROWSERLESS_CONTROL_URL"`
+	OpenAI            OpenAIConfig       `envPrefix:"OPENAI_"`
+	GoogleSearch      GoogleSearchConfig `envPrefix:"GOOGLE_SEARCH_"`
+	S3                S3Config           `envPrefix:"S3_"`
+	BrowserControlUrl string             `env:"BROWSER_CONTROL_URL" envDefault:"http://localhost:9222"`
 }
 
 func init() {

internal/pkg/webreader/fetcher/browser.go

@@ -8,16 +8,13 @@ import (
 	"net/http"
 	"strings"
 	"time"
+	"vibrain/internal/pkg/config"
 	"vibrain/internal/pkg/webreader"
 
 	"github.com/go-rod/rod"
 	"github.com/go-rod/rod/lib/proto"
 )
 
-const (
-	defaultControlURL = "http://localhost:9222"
-)
-
 // BrowserConfig extends the base Config with browser-specific options
 type BrowserConfig struct {
 	Timeout        int    `json:"timeout"`          // Timeout in seconds
@@ -35,7 +32,7 @@ type BrowserFetcher struct {
 func NewDefaultBrowserConfig() BrowserConfig {
 	return BrowserConfig{
 		Timeout:        30,
-		ControlURL:     defaultControlURL,
+		ControlURL:     config.Settings.BrowserControlUrl,
 		ScrollToBottom: true,
 	}
 }

internal/pkg/webreader/fetcher/http.go

@@ -29,7 +29,6 @@ type HTTPOption func(*HTTPConfig)
 type HTTPFetcher struct {
 	client *http.Client
 	config HTTPConfig
-	closed bool
 }
 
 func DefaultHTTPConfig() HTTPConfig {
@@ -76,10 +75,6 @@ func NewHTTPFetcher(opts ...HTTPOption) (*HTTPFetcher, error) {
 
 // Fetch implements the Fetcher interface
 func (f *HTTPFetcher) Fetch(ctx context.Context, url string) (*webreader.Content, error) {
-	if f.closed {
-		return nil, fmt.Errorf("fetcher is closed")
-	}
-
 	var lastErr error
 	retries := f.config.RetryCount + 1
 
@@ -136,11 +131,6 @@ func (f *HTTPFetcher) doFetch(ctx context.Context, url string) (*webreader.Conte
 
 // Close implements the Fetcher interface
 func (f *HTTPFetcher) Close() error {
-	if f.closed {
-		return nil
-	}
-	f.closed = true
-	f.client.CloseIdleConnections()
 	return nil
 }
 

internal/pkg/webreader/fetcher/jina.go

@@ -42,7 +42,6 @@ type jinaResponse struct {
 type JinaFetcher struct {
 	client *http.Client
 	config JinaConfig
-	closed bool
 }
 
 func DefaultJinaConfig() JinaConfig {
@@ -78,10 +77,6 @@ func NewJinaFetcher(opts ...JinaOption) (*JinaFetcher, error) {
 
 // Fetch implements the Fetcher interface
 func (f *JinaFetcher) Fetch(ctx context.Context, url string) (*webreader.Content, error) {
-	if f.closed {
-		return nil, fmt.Errorf("fetcher is closed")
-	}
-
 	// Prepare the Jina API URL
 	jinaURL := fmt.Sprintf("%s/%s", jinaHost, url)
 
@@ -129,10 +124,5 @@ func (f *JinaFetcher) Fetch(ctx context.Context, url string) (*webreader.Content
 
 // Close implements the Fetcher interface
 func (f *JinaFetcher) Close() error {
-	if f.closed {
-		return nil
-	}
-	f.closed = true
-	f.client.CloseIdleConnections()
 	return nil
 }