Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geolocate control #99

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add geolocate control #99

merged 1 commit into from
Sep 25, 2024

Conversation

jokroese
Copy link
Member

@jokroese jokroese commented Sep 2, 2024

Related Issues

Closes #98

Proposed Changes (Optional)

  • users can find themselves on the map with clicking a button
  • only requests location if they click, so still totally private and in the user's control
  • even if they do grant permission, the location is only shared on the client side.

Additional context (Optional)

I haven't discussed this change with anyone yet. Would be great if you can share any thoughts at #98.

- users can find themselves on the map with a click
- only requests location if they click, so still totally private and in user's control
@jokroese jokroese added the enhancement New feature or request label Sep 2, 2024
@jokroese jokroese requested a review from narcode September 2, 2024 15:46
@jokroese jokroese self-assigned this Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for qtmmirror ready!

Name Link
🔨 Latest commit 1f416c1
🔍 Latest deploy log https://app.netlify.com/sites/qtmmirror/deploys/66d5dde019c62900089167f5
😎 Deploy Preview https://deploy-preview-99--qtmmirror.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jokroese jokroese mentioned this pull request Sep 2, 2024
@nielsbom
Copy link
Collaborator

nielsbom commented Sep 2, 2024

Excellent!

Maybe it's kind to somehow tell people "we don't save your location in any way"? But that could be a different issue. This one is short and sweet.

Copy link
Collaborator

@rayenjaramitrovich rayenjaramitrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Been wanting this forever.

@rayenjaramitrovich rayenjaramitrovich merged commit 9e90370 into main Sep 25, 2024
7 checks passed
@rayenjaramitrovich rayenjaramitrovich deleted the user-geolocation branch September 25, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add geolocation option
3 participants