Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing type hints in functions #453

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

hh-space-invader
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@joein joein changed the base branch from add-mypy to main January 28, 2025 22:16
@@ -9,7 +9,7 @@
from typing_extensions import TypeAlias


PathInput: TypeAlias = Union[str, os.PathLike]
PathInput: TypeAlias = Union[str, os.PathLike[str]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessarily str, it might be pathlib.Path

@joein joein force-pushed the add-missing-fun-type-hints branch from 8865b7d to 5045986 Compare January 29, 2025 07:43
@joein joein self-requested a review January 29, 2025 11:08
@joein joein merged commit 993dcd5 into main Jan 29, 2025
17 checks passed
@joein joein deleted the add-missing-fun-type-hints branch January 29, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants